Hardsuits now block defibulators #2251
Conversation
github-actions
bot
added
S: Needs Review
Changes: YML
|
Gonna need to make sure that softsuits, (Prisoner, Emergancy, Basic, Clown, Mime, Syndicate) dont, and yes clown and mime are softsuits, not hardsuits (despite their name) |
|
💯💯 |
Sounds good, when the required PR actually gets merged I'll do more testing to make sure it works on the right things and stuff |
Also currently where that's placed- it looks like EVERY outer slot item will block defib (would include vox tank harnesses i believe) also you should be testing it BEFORE it gets merged |
How? I mean I guess I could like chery pick the required PR ahead of time but I personally don't think that's worth the effort. I mostly made this early so people could give their opinions. If people don't want it, then I wont bother putting the work in finding all the weird hardsuit edge cases |
pull the merge to your dev or make a dev enviro on wizden (which its already merged) and test there, cause we use similar stuff so |
|
|
||
| namespace Content.Shared.DeltaV.BlockDefibrillator; | ||
|
|
||
| [RegisterComponent, NetworkedComponent] |
| { | ||
|
|
||
| [DataField] | ||
| public string OnBlockPopupMessage = "The defibrillator cannot find a pulse through the armor!"; |
|
|
||
| public sealed class BlockDefibrillatorSystem : EntitySystem | ||
| { | ||
| [Dependency] private readonly SharedPopupSystem _popupSystem = default!; |
| @@ -146,6 +146,7 @@ | |||
| flatReductions: | |||
| Heat: 10 # the average lightbulb only does around four damage! | |||
| slots: OUTERCLOTHING | |||
| - type: BlockDefibrillator // Delta-V | |||
|
|
||
| namespace Content.Shared.DeltaV.BlockDefibrillator; | ||
|
|
||
| [RegisterComponent, NetworkedComponent] |
| @@ -146,6 +146,7 @@ | |||
| flatReductions: | |||
| Heat: 10 # the average lightbulb only does around four damage! | |||
| slots: OUTERCLOTHING | |||
| - type: BlockDefibrillator // Delta-V | |||
There was a problem hiding this comment.
Remember to double check all the weird edge cases for hardsuits. There are a lot :(
|
This isn't too hard to fix but I have more interesting things I'd rather work on! Anyone feel free to copy / re-open this (The code isn't very good so I wouldn't recommend it but whatever 😆) |
About the PR
Title! Defibs now are blocked by hardsuits.
Why / Balance
I asked in the discord, majority of people seemed to want it. It makes sense and will make medical have to think about defibbing fully armored security.
Also, requires:
space-wizards/space-station-14#31147
To be merged before it works! (I'll also add comments and localization stuff when that happens as I want it fully merged before doing testing and stuff)
Media
todo
Requirements
Changelog
🆑