Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam Devastator (RPG Replacement) and Beam Cannon (research) #2231

Merged
merged 32 commits into from
Nov 29, 2024

Conversation

Stop-Signs
Copy link
Contributor

@Stop-Signs Stop-Signs commented Nov 18, 2024

About the PR

Adds the beam devastator, a much more powerful version of the beam cannon in #2221. Since the RPG is on the chopping block this could serve as a worthy replacement. It shoots several small damage beams a second and can be sprayed effectively. mag size of 500. takes incredibly long to recharge (about 10 minutes with a standard recharger), however it can be slotted into a cage recharger which has also been buffed, at this rate it takes ~3 minutes to fully charge.

#2221 was closed as this PR adds it anyway, adds the beam cannon as well to the sec research tree

IMPORTANT NOTE!!!!!!: This item is UNOBTAINABLE and in order to replace the RPG will need to be MAPPED/MIGRATED to do so. I am willing to map it myself but I don't exactly know how to do so.

Why / Balance

Curators were looking for an RPG replacement, this gun has a fairly low TTK and instead relies on sustained fire to be as oppressively as it is. A worthy successor to the RPG while not being just a no-skill one-tapinator

Technical details

Media

Github says the videos are too big. heres the sprite instead
base

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.>

🆑

  • add: Added the new Beam Cannon for Epi to research.
  • tweak: The Cage Recharger can now charge lasers.

@Stop-Signs Stop-Signs requested review from IamVelcroboy and a team as code owners November 18, 2024 19:45
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi Changes: Audio Changes any audio files labels Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

RSI Diff Bot; head commit 902146b merging into c084a4f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/beam_cannon.rsi

State Old New Status
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/beam_devestator.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Projectiles/projectiles.rsi

State Old New Status
beam Added
impact_laser Added
muzzle_laser Added

Edit: diff updated after 902146b

@Radezolid
Copy link
Contributor

Also, it won't really help as a breaching tool unless you're breaching an airlock since the lasers go thru the girders + the slowdown, you can just use a breaching charge instead

@Lyndomen
Copy link
Contributor

Requesting review, should be good to go honestly as it's balance approved & the RPG replacement happens per map.

@CybersunOperative
Copy link

RPG REPLACEMENT REAL RAAAAGH.
I like it. It feels more suppressive instead of "Fire and Forget" antag obliterator. Zombie Mains weeping.

This sentiment is shared by direction. (Who also hate the RPG) :blunt:
I would ask mappers after this PR is merged about this change.

@LadyDanger2743
Copy link

Really the only thing that I'm curious about is how effective it is at clearing standard and reinforced walls. Other than that, it has the Direction Seal Of Approval.

@Stop-Signs
Copy link
Contributor Author

Really the only thing that I'm curious about is how effective it is at clearing standard and reinforced walls. Other than that, it has the Direction Seal Of Approval.

I did test this, it takes over 100 shots to do so!

@LadyDanger2743
Copy link

Really the only thing that I'm curious about is how effective it is at clearing standard and reinforced walls. Other than that, it has the Direction Seal Of Approval.

I did test this, it takes over 100 shots to do so!

Alright, that's all I really need. This has Direction's approval to merge.

@MilonPL MilonPL added the S: Awaiting Changes Do not merge due to requested changes label Nov 26, 2024
@github-actions github-actions bot added the size/L 256-1023 lines label Nov 27, 2024
@Stop-Signs Stop-Signs requested a review from MilonPL November 27, 2024 00:11
@github-actions github-actions bot added S: Needs Review and removed S: Awaiting Changes Do not merge due to requested changes labels Nov 27, 2024
@therealDLondon
Copy link
Member

This isnt code approval, but its approved as far as im concerned.
Direction approved, millions must merge

@deltanedas
Copy link
Member

removed the beam devastator line from cl as this pr doesnt replace anything and it isnt likely to get migrated for every map

@deltanedas deltanedas merged commit d9b3859 into DeltaV-Station:master Nov 29, 2024
16 of 18 checks passed
@Stop-Signs Stop-Signs deleted the Meow-(RPG-Replacement) branch January 9, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants