Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the t3 lockout #2144

Merged
merged 13 commits into from
Nov 11, 2024
Merged

Conversation

Stop-Signs
Copy link
Contributor

@Stop-Signs Stop-Signs commented Nov 7, 2024

About the PR

Removed the lockout on T3 research. also forces you to get all techs in any given tier before moving on.

Why / Balance

Epi always getting t3 industrial just so they can have funny bags and powercells. this creates an issue where adding t3 tech (or anything service or arsenal related) is useless as epi will almost never research it.

Technical details

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • remove: Removed the T3 Lockout on epi techs

@Stop-Signs Stop-Signs requested a review from a team as a code owner November 7, 2024 19:35
@github-actions github-actions bot added S: Needs Review Changes: C# Changes any cs files labels Nov 7, 2024
@Stop-Signs Stop-Signs changed the title Fix research Remove the t3 lockout Nov 7, 2024
@Avalon-Proto
Copy link
Contributor

Now we just need to make it so they need to research x amount of T1/T2 to level up tech

@Stop-Signs
Copy link
Contributor Author

Now we just need to make it so they need to research x amount of T1/T2 to level up tech

This is already a thing, i could just raise the value

@Stop-Signs
Copy link
Contributor Author

Oh this also fixes an upstream error where you cant put research disks in the server without your dev env crashing

Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noob change the lockout tier to 4 inside of the prototypes instead of whatever this is

@MilonPL
Copy link
Member

MilonPL commented Nov 7, 2024

Oh this also fixes an upstream error where you cant put research disks in the server without your dev env crashing

pr it upstream then

@Stop-Signs
Copy link
Contributor Author

Oh this also fixes an upstream error where you cant put research disks in the server without your dev env crashing

pr it upstream then

its already pr'd upstream ;)

@MilonPL
Copy link
Member

MilonPL commented Nov 7, 2024

cherry pick in a separate PR

@Stop-Signs Stop-Signs requested a review from a team as a code owner November 7, 2024 20:34
@Stop-Signs Stop-Signs requested a review from MilonPL November 7, 2024 20:34
@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 7, 2024
Signed-off-by: Stop-Signs <[email protected]>
@ewokswagger
Copy link
Contributor

cherry pick in a separate PR

This is said pr Its already marked as approved so I imagine it won't be long before it's here anyways.

@Stop-Signs Stop-Signs requested a review from MilonPL November 7, 2024 23:27
MilonPL
MilonPL previously requested changes Nov 7, 2024
Resources/Prototypes/Research/disciplines.yml Show resolved Hide resolved
Resources/Prototypes/Research/disciplines.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Research/disciplines.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Research/disciplines.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Research/disciplines.yml Outdated Show resolved Hide resolved
@Stop-Signs Stop-Signs requested a review from MilonPL November 7, 2024 23:50
Colin-Tel
Colin-Tel previously approved these changes Nov 11, 2024
Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and the curators I've asked.

@Spielern
Copy link

Epi, with the recent RE changes, has become a lot more stale. I just had a round 30 minutes ago where I had Svalinns, Microreactor Cells, Speed Boots, and Bluespace bags off of a single research server. The only thing stopping people from doing this every shift is the occasional RA that goes unchecked and raises glimmer by 500 with artifacts. This just seems insanely overpowered. I already dislike how epi's balance is, and I can see the department getting way more unbalanced and unfun with this. This could be a unique opinion to me, but I play an insane amount of epi and have heard similar discontent from other epi players in game through LOOC.

This reverts commit 7077997.
@Stop-Signs
Copy link
Contributor Author

Epi, with the recent RE changes, has become a lot more stale. I just had a round 30 minutes ago where I had Svalinns, Microreactor Cells, Speed Boots, and Bluespace bags off of a single research server. The only thing stopping people from doing this every shift is the occasional RA that goes unchecked and raises glimmer by 500 with artifacts. This just seems insanely overpowered. I already dislike how epi's balance is, and I can see the department getting way more unbalanced and unfun with this. This could be a unique opinion to me, but I play an insane amount of epi and have heard similar discontent from other epi players in game through LOOC.

Not once in here did you mention the other t3's that get ignored by epi. bluespace syringes and beakers, as well as the advanced laser pistol and the Advanced truncheon are all things that epi doesn't benefit greatly from, but other departments do. the problem this PR seeks to solve is epistemics researching only for themselves instead of for everyone. If cloning got added to the civillian services tree as a t3, do you think epi would get that instead of their designer bags and needlessly infinite power cells?

@deltanedas deltanedas merged commit cabf4cd into DeltaV-Station:master Nov 11, 2024
11 checks passed
@Spielern
Copy link

Not once in here did you mention the other t3's that get ignored by epi. bluespace syringes and beakers, as well as the advanced laser pistol and the Advanced truncheon are all things that epi doesn't benefit greatly from, but other departments do. the problem this PR seeks to solve is epistemics researching only for themselves instead of for everyone. If cloning got added to the civillian services tree as a t3, do you think epi would get that instead of their designer bags and needlessly infinite power cells?

I didn't mention any of the other T3s because I believe we should be heading the opposite way of this PR with Epi. IMO, T3 technologies were designed to be extremely good and rare, not something the crew is entitled to.
A large reason that I have seen Industrial being the only T3 chosen recently is BECAUSE of the fact that speed boots are able to be obtained for free. Before that, it was really just a coin flip depending on who is playing. I'd see arsenal and civilian both be picked fairly often, although Industrial still was the most common. Before the arsenal changes, all of the T3s except civilian benefit Epi AND the crew. People would just choose whatever they felt like in the moment, or whatever RA #3 accidentally pressed. I see no issue with how it was before, and still completely regret the RE changes.
If your sole goal is to make Epi less selfish with their T3 picks, I firmly believe reverting the RE additions would be much more productive for both sides.

@deltanedas
Copy link
Member

  • bluespace beakers have basically no use for epi, and limited use for med since chems arent infinite and if you are farming oxygen you will quickly run into the sink generation speed limit
  • so many jobs benefit from speedboots, for one sec
  • realistically only salv needs bags of holding, everyone else can manage a satchel within reason, bar atmos or paramed storing their suits
  • engi, med, sec, salv all benefit from microreactors which is why theyre such a strong pick already
  • t3 arsenal is solely for warops and syndies emagging lathes, you never see it otherwise
  • t3 experimental is a 100% meme that benefits noone. half the time its made is just for exploiting 1 of 1000 bugs with the qsi, theres very little utility for anyone

@Stop-Signs Stop-Signs deleted the fix-research branch January 9, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants