Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforcer, m-90 and adjutant wield sprites #2134

Closed
wants to merge 3 commits into from

Conversation

MilonPL
Copy link
Member

@MilonPL MilonPL commented Nov 7, 2024

About the PR

gives the 64x enforcer sprite to adjutant (it was commented out for whatever reason, but works)
gives the lecter sprite to enforcer and M-90s (it's generic enough no one will notice)
might comment out vulcans in a separate PR so it's easier to revert in the future when we get proper sprites, but because of licensing I can't give it the lecter sprite

carabinenogl.rsi meta.json reformat because holy fuck

Why / Balance

#1939 open for ages yet no one does anything so

Media

Enforcer/M-90
image

Adjutant
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Added the Enforcer, M-90 and Adjutant wield sprites.

@MilonPL MilonPL requested review from IamVelcroboy and a team as code owners November 7, 2024 03:12
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi S: Needs Review labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

RSI Diff Bot; head commit f691bee merging into 91afa8f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/carbinenogl.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Shotguns/enforcer.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after f691bee

@Unkn0wnGh0st333
Copy link
Contributor

Hilarious I was finna ask you if TJ was getting this done

@MilonPL
Copy link
Member Author

MilonPL commented Nov 7, 2024

Hilarious I was finna ask you if TJ was getting this done

clearly not seeing how long the issue is open for, but you can sprite Vulcans so I don't have to comment it out

@ewokswagger
Copy link
Contributor

My partner who does sprite work was just asking about this they can get on this if it's not claimed already.

@MilonPL
Copy link
Member Author

MilonPL commented Nov 7, 2024

My partner who does sprite work was just asking about this they can get on this if it's not claimed already.

Having custom sprites would be so much better than reusing the generic one, this was meant as a band-aid because no one would sprite it. But feel free to!

@chamomileteatime
Copy link

I'm the partner Ewokswagger mentioned; I'm currently looking into making sprites for this stuff (aka crying trying to navigate all the folders)

@deltanedas
Copy link
Member

we will wait for your new sprites then

@MilonPL MilonPL marked this pull request as draft November 11, 2024 15:25
@TadJohnson00
Copy link
Contributor

@chamomileteatime Hi, I'm TJ. I hear you're taking on the work of setting up wielded sprites for some of my work. Feel free to give me a ping on Discord and I can help you out with that.

@ewokswagger
Copy link
Contributor

Sorry they have been a bit swamped with exam season but they say they will reach out to you on Discord once that's over. @TadJohnson00

@MilonPL MilonPL closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants