port borg preferred name from goob #2123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: UI
Changes: C#
|
Chat is this real |
Goob moment. What is the max length for a name? 32? |
|
32 yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
title, minus the 5000 random whitespace and indent changes
Why / Balance
rip borg that threw a tantrum over mysta not renaming it
Technical details
db migrations renamed from BorgName to GoobBorgName but the db stuff is still highly questionable
Media
its real
if you set a name longer than the limit it still gets cropped to 32 chars
Requirements
Breaking changes
no
Changelog
🆑 PoTeletubby, deltanedas