Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail carrier hood. AAAAAAAAAAAAH!! #2113

Merged
merged 16 commits into from
Dec 6, 2024
Merged

mail carrier hood. AAAAAAAAAAAAH!! #2113

merged 16 commits into from
Dec 6, 2024

Conversation

Monotheonist
Copy link
Contributor

@Monotheonist Monotheonist commented Nov 4, 2024 •
edited
Loading

About the PR

fixes #781, gives the mail carrier a hood. Literally playable 😃
This gives the mail carrier a hood to their coat.

Why / Balance

It's crucial for the balance of the game, mail carriers everywhere have been deprived of their right for TOO LONG. I'm just kidding but I saw that I could fix this issue and so I did.

Technical details

Currently YAML and sprites.

Media

This is a hood, the sprite's in the diff. I don't got much else to say.

Requirements

Breaking changes

Changelog

No CL no fun.

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

RSI Diff Bot; head commit cc7dfaa merging into 60f3949
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Head/Hoods/Coat/hoodmail.rsi

State Old New Status
equipped-HELMET Added
icon Added

Edit: diff updated after cc7dfaa

@Monotheonist Monotheonist changed the title Sprite the actual hood, tell me what I'm missing. mail carrier hood. AAAAAAAAAAAAH!! Nov 4, 2024
@Monotheonist
Copy link
Contributor Author

why the fuck did i name it that. oh my god. crying.

@deltanedas
Copy link
Member

  1. add a new hood entity, copy paste the logistics one and change the id/sprite/name
  2. change the coats parent to ClothingOuterWinterCoatToggleable
  3. add
- type: ToggleableClothing
  clothingPrototype: ClothingHeadHatHoodWinterMailCarrier

to the mail carrier winter coat

@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 15, 2024
@Monotheonist Monotheonist marked this pull request as ready for review November 15, 2024 10:45
@Monotheonist Monotheonist requested review from IamVelcroboy and a team as code owners November 15, 2024 10:45
@Monotheonist
Copy link
Contributor Author

I addressed it, my small yaml PR should be ready for your consideration @deltanedas

@Monotheonist
Copy link
Contributor Author

There you go, are we good?

deltanedas
deltanedas previously approved these changes Nov 16, 2024
View reviewed changes
@deltanedas deltanedas enabled auto-merge (squash) November 16, 2024 14:05
@github-actions github-actions bot added the size/S 16-63 lines label Nov 24, 2024
@Monotheonist
Copy link
Contributor Author

The tests aren't testing 😿

@Monotheonist Monotheonist mentioned this pull request Nov 24, 2024
Merged
2 tasks
auto-merge was automatically disabled December 6, 2024 04:09

Head branch was pushed to by a user without write access

@Monotheonist
Copy link
Contributor Author

I'M FREE FROM THE CONSTANT TEST FAILS!!! @deltanedas @MilonPL

@MilonPL MilonPL merged commit 868297b into DeltaV-Station:master Dec 6, 2024
16 checks passed
@Monotheonist Monotheonist deleted the mail-carrier-in-da-hood-ops branch December 6, 2024 05:37
sleepyyapril added a commit to Simple-Station/Einstein-Engines that referenced this pull request Feb 4, 2025
@sleepyyapril
Deltamerge Part 1 (#1697)
9901f46 
# Description

## **!!! DO NOT "Squash and commit", ONLY "Create a merge commit" !!!**

Merges a lot of PRs from Delta-V, most of these are plain YML changes so
they shouldn't cause wizmerge-like issues.
- DeltaV-Station/Delta-v#1008 
- DeltaV-Station/Delta-v#1077
- DeltaV-Station/Delta-v#1092
- DeltaV-Station/Delta-v#1094
- DeltaV-Station/Delta-v#1143
  - Excluded the lobby art with DeltaV branding.
- DeltaV-Station/Delta-v#1176
- DeltaV-Station/Delta-v#1209
- DeltaV-Station/Delta-v#1227
- DeltaV-Station/Delta-v#1252
- not directly cherry-picked due to harpy singing now being stored in a
different file, but implemented the same thing in
df50140
- DeltaV-Station/Delta-v#1261
- DeltaV-Station/Delta-v#1271
- DeltaV-Station/Delta-v#1272
- Also made available to Humans and Tajarans like the other Felinid
tails.
- DeltaV-Station/Delta-v#1426
- DeltaV-Station/Delta-v#1462
- DeltaV-Station/Delta-v#1542
- DeltaV-Station/Delta-v#1759
- DeltaV-Station/Delta-v#1763
- DeltaV-Station/Delta-v#1765
- DeltaV-Station/Delta-v#1780
- DeltaV-Station/Delta-v#1781
- DeltaV-Station/Delta-v#1804
- DeltaV-Station/Delta-v#1814
- TODO in another pr, vulp sprite for the colorable neck gaiter (PR only
adds vulp states to pre-existing black/red neck gaiters)
- DeltaV-Station/Delta-v#1828
  - Added to Loadouts for Corpsman, costs 2 points.
- DeltaV-Station/Delta-v#1838
- DeltaV-Station/Delta-v#1877
- DeltaV-Station/Delta-v#1905
  - Added to Loadout Uniforms, costs 1 point. 
- DeltaV-Station/Delta-v#1910
- DeltaV-Station/Delta-v#1935
- DeltaV-Station/Delta-v#1946
- DeltaV-Station/Delta-v#1994
- DeltaV-Station/Delta-v#1997
- DeltaV-Station/Delta-v#1998
- DeltaV-Station/Delta-v#2031
- DeltaV-Station/Delta-v#2089
- DeltaV-Station/Delta-v#2113
- DeltaV-Station/Delta-v#2213
- DeltaV-Station/Delta-v#2209
- DeltaV-Station/Delta-v#2210
- Prerequisite Wizden PR added:
space-wizards/space-station-14#29243
- Prerequisite Wizden PR added:
space-wizards/space-station-14#30856
- DeltaV-Station/Delta-v#2233
- DeltaV-Station/Delta-v#2245
- DeltaV-Station/Delta-v#2250
- DeltaV-Station/Delta-v#2266
- DeltaV-Station/Delta-v#2267
- DeltaV-Station/Delta-v#2294
- DeltaV-Station/Delta-v#2307
- DeltaV-Station/Delta-v#2318
- DeltaV-Station/Delta-v#2398
- DeltaV-Station/Delta-v#2410
- DeltaV-Station/Delta-v#2462
- DeltaV-Station/Delta-v#2478
- DeltaV-Station/Delta-v#2501
- DeltaV-Station/Delta-v#2503
- DeltaV-Station/Delta-v#2504
- Prerequisite Wizden PR added:
space-wizards/space-station-14#30957
- DeltaV-Station/Delta-v#2524
- DeltaV-Station/Delta-v#2539
- DeltaV-Station/Delta-v#2635
- Prerequisite Wizden PR added:
space-wizards/space-station-14#32193
- Prerequisite Wizden PR added:
space-wizards/space-station-14#32327

## Changelog

Too much changes to count so some changes are unlisted

:cl: Several Contributors
- add: Added Lone Digger by Caravan Palace to the jukebox! (by MilonPL)
- add: Added Deck The Halls by Kevin Macleod to the jukebox! (by
Lyndomen)
- tweak: Now medical belts have a slot for medkits. (by Radezolid)
- add: Added a way for muskets, flintlocks, and musket cartridges (NOT
.60) to be crafted. (by Tryded)
- add: Added Vulpkanin-specific sprites to a lot of helmets and masks.
(by Adrian16199, TadJohnson00)
- add: Security dogs (such as Laika) now have Vulpkanin vocal emotes.
Howl! (by Remuchi)
- add: Split the Emag into the Cryptographic Sequencer and the Airlock
Access Override. (by Warmechanic)
- add: Added Corpsman Glasses, no more getting flashed as Corpsman! Also
available in Loadouts. (by Unkn0wnGh0st333)
- add: Harpies can now mimic harps! (by TheOneWhoIsManyFrame)
- tweak: Cats will now play with mouse toys. (by Deltanedas)
- add: Added a black turtleneck, available in Loadouts! (by Aikakakah)
- add: Added the Binary Translator Key to the uplink costing 1 TC and
the listening post operative headset. (by Radezolid)
- add: Spesos now have a new pretty look transferred from the Frontier
Station. (by whatston3)
- add: The home-run bat has been re-added to the traitor uplink.
- add: Added the CrystalThistle, mutated from the Galaxythistle that
generates Quartzite which when heated produces glass sheets. (by
jimmy12or)
- add: Added a Ghost Pepper! A friendly looking Pepper that's so Spicy,
it hurts! (by jimmy12or)
- add: Added a Cosmic Revenant! A spooky mutation of the Ghost pepper
that produced Ectoplasm. (by jimmy12or)
- add: Added blue and purple tomato soup, made using Blue Tomatoes. (by
DisposableCrewmember42)
- add: Added new drinks: the double ice cream (by dge21) and Dr. Gibb
Blood Red (by BlitzTheSquishy).
- add: Some drink reactions now require shaking with the shaker or
stirring with a spoon. (by Vermidia)
- add: Added "Selene" wing customization option for moths (by
boogiebogus)
- add: Added the tiger tail sprite for Felinids, Humans and Tajarans.
(by Adrian16199)
- add: NanoTrasen has established business relations with HydroCo! You
can now order powdered milk and juice via your Logistics department. (by
DisposableCrewmember42)
- tweak: Bar and kitchen shelves no longer restrict the items that can
be placed in them. (by Velcroboy)
- tweak: Bookshelves can now fit any kind of item, not just books. (by
Deltanedas)
- add: New magic crayons have appeared in the sector, artists rejoice!
(by AvalonProto)
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Feb 10, 2025
@Monotheonist @angelofallars
mail carrier hood. AAAAAAAAAAAAH!! (DeltaV-Station#2113)
b755d04 
* Sprite the actual hood, tell me what I'm missing.

* Does the yaml thing, because me two weeks ago was a tired

* moving the comment

* Build and test will you ever be satisfied?

* THE LINTER

* Mono breaks robusttoolbox with his shitcode

* Revert "Mono breaks robusttoolbox with his shitcode"

This reverts commit 392b3ee.

* Revert "THE LINTER"

This reverts commit 3331e4d.

* Okay let's try this again

* Mono, you press Tab too much.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilonPL MilonPL MilonPL approved these changes

@deltanedas deltanedas deltanedas left review comments

@IamVelcroboy IamVelcroboy Awaiting requested review from IamVelcroboy

Assignees
No one assigned
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mail carrier winter coat has no hood
3 participants
@Monotheonist @deltanedas @MilonPL