Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable AI #2018

Merged
merged 4 commits into from
Dec 1, 2024
Merged

enable AI #2018

merged 4 commits into from
Dec 1, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Oct 16, 2024

About the PR

should only be merged once all maps have prs open (they fail tests without this so cant merge them without trolling tests)

list to edit as prs are merged

Changelog

🆑

  • add: Enabled AI for all stations except Chibi!

@deltanedas deltanedas requested a review from a team as a code owner October 16, 2024 21:41
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files labels Oct 16, 2024
@JustTNE
Copy link
Contributor

JustTNE commented Oct 17, 2024

To my knowledge, it was said on discord that every station but Chibi would get AI, so it may be worth discussing if Chibi should be a requirement for this PR or not.

@Colin-Tel
Copy link
Contributor

bumping with the opening of #2049

@MilonPL
Copy link
Member

MilonPL commented Oct 26, 2024

bumping with the opening of #2049

Aren't you a maintainer? You can edit the issue and link it.

@Colin-Tel
Copy link
Contributor

Aren't you a maintainer? You can edit the issue and link it.

b-but this is a PR and not an issue >w<

@MilonPL
Copy link
Member

MilonPL commented Oct 26, 2024

b-but this is a PR and not an issue >w<

image

@JustTNE
Copy link
Contributor

JustTNE commented Nov 7, 2024

Okay there's some things that might need clearing up with this PR to me.

Will cyborgs have their "answers to" round join message changed to the Station AI (as the station AI is now command) instead of the mystagogue? Seems like that's missing.

Although not necessarily required, I am curious what power the AI has over cyborgs. Does the AI get to define what "crew" is or will an antimov AI be at odds with its own cyborgs?

If the AI did get to define crew, we might see an antimov AI define itself as the only crew member and order the cyborgs to do things, but this would have the be clarified for cyborgs somewhere.

@deltanedas
Copy link
Member Author

Will cyborgs have their "answers to" round join message changed to the Station AI (as the station AI is now command) instead of the mystagogue? Seems like that's missing.

upstream hasnt added borg slaving yet

other issues would be fixed with borgs slaved to the ai having laws synced

@JustTNE
Copy link
Contributor

JustTNE commented Nov 7, 2024

I'm specifically referring to the text at the beginning of the round that states "as a cyborg you answer directly to the mystagogue. Special circumstances might change this". Other issue makes sense, thanks!

@JustTNE
Copy link
Contributor

JustTNE commented Nov 10, 2024

It would probably be good if we let the AI call the shuttle using its own internal communications console instead of forcing the AI to go to the bridge and call the shuttle from there.

There are some cases where the bridge is unpowered/the comms console destroyed, where I think it would make perfect sense for the AI to be able to call the shuttle on its own. The only considerations to be had for this in my mind are "what if the AI is antimov", but in my eyes we already have a rule against extending the round needlessly, and I honestly doubt we will see command un-anchoring the comms console so the AI can't recall the shuttle.
Swapping this to true does the trick:

I don't know if this is something you would want to add to this pull request, or if you would like me to make a new pull request for this.

@Radezolid
Copy link
Contributor

It would probably be good if we let the AI call the shuttle using its own internal communications console instead of forcing the AI to go to the bridge and call the shuttle from there.

I think it's a good thing that the AI can't call the shuttle in their action menu, read this comment. If for some reason AI want's to evacuate due to it's laws forcing them to the only thing crew can do is go to the extreme and remove the ability of the AI to interact with the station, which is a overkill in my opinion. If you don't want the AI to recall you only need to snip the AI wire in the consoles.

This was referenced Nov 27, 2024
@deltanedas deltanedas merged commit facb6c0 into DeltaV-Station:master Dec 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants