Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 New peppers! Ghost and Cosmic Revenant! #1542

Merged
merged 10 commits into from
Jul 27, 2024

Conversation

jimmy12or
Copy link
Contributor

About the PR

This PR Adds 2 new Peppers! One is a Ghost Pepper that's so spicy it hurts, and the other is the Cosmic Revenant Pepper that produces Ectoplasm for Epistemics.

Why / Balance

Botany still needs more unique plants.
The Ghost pepper is meant to inspire more food recipes primarily and to work as an in-between for the Cosmic Revenant.
The Cosmic Revenant is a Revenant inspired Pepper that is intended to be difficult to get due to producing Ectoplasm for Epistemics.

Technical details

Rather basic code to add 2 new plants, one with animated sprites for the dead, Harvest, and produce.
Mutation line goes Chili > Ghost Pepper > Cosmic Revenant.
Assuming you don't get the Chilly Pepper.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    Screenshot 2024-07-26 041233
    Screenshot 2024-07-26 041751
    Screenshot 2024-07-26 041819
    Screenshot 2024-07-26 041308
Screen.Recording.2024-07-26.042218.mp4
Screen.Recording.2024-07-26.042326.mp4
Screen.Recording.2024-07-26.042349.mp4

Breaking changes

None that I am aware of

Changelog

🆑

  • add: Added a Ghost Pepper! A friendly looking Pepper that's so Spicy, it hurts!
  • add: Added a Cosmic Revenant! A spooky mutation of the Ghost pepper that produced Ectoplasm.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

RSI Diff Bot; head commit a11bfc9 merging into dd7335e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Specific/Hydroponics/Cosmic_Revenant.rsi

State Old New Status
dead Added
harvest Added
produce Added
seed Added
stage-1 Added
stage-2 Added
stage-3 Added
stage-4 Added
stage-5 Added
stage-6 Added

Resources/Textures/DeltaV/Objects/Specific/Hydroponics/Ghost_Pepper.rsi

State Old New Status
dead Added
harvest Added
produce Added
seed Added
stage-1 Added
stage-2 Added
stage-3 Added
stage-4 Added
stage-5 Added
stage-6 Added

Edit: diff updated after a11bfc9

@jimmy12or jimmy12or marked this pull request as draft July 27, 2024 06:09
@jimmy12or jimmy12or marked this pull request as ready for review July 27, 2024 06:09
@deltanedas
Copy link
Member

infinite ectoplasm is just stupidly broken epi would get hundreds of drains

@jimmy12or
Copy link
Contributor Author

infinite ectoplasm is just stupidly broken epi would get hundreds of drains

When showing off CrystalThistle, I was asked to make a plant that did Ectoplasm, which I had also been considering before. Revs are a royal pain and often just grief by spacing Evac and/or the entire station which is honestly a boring way to end a round. This gives Epi a potential way to help prevent Revs from happening in the first place, and since it's a plant that needs 2 mutations along with the first mutation competing with another, it's not going to be an easy one to get every round unless the botanist is really skilled or lucky at their job.

@deltanedas
Copy link
Member

you can say that but omnizine is mass produced basically every round, ectoplasm would be the same. might as well remove the 500 glimmer objective or youd have to bomb botany roundstart

@DangerRevolution
Copy link
Contributor

+1 for removing 500 glimmer

@jimmy12or
Copy link
Contributor Author

you can say that but omnizine is mass produced basically every round, ectoplasm would be the same. might as well remove the 500 glimmer objective or youd have to bomb botany roundstart

Using Omni as the example here works well. Omnizine is easy to get since it takes only one plant mutation on a plant that has no other mutations on it's pool for the time being, and yet while it is obtained most rounds, it isn't made every round. The chili plant has 2 options for mutation with this added. It has a 50:50 chance of going to Chilly peppers or ghost pepper. Then you have to get lucky or try very carefully to get it to the Cosmic Rev stage without the plant dying, producing a hazardous gas, or Kudzu'ing, this on top of the same hazards while making the ghost peppers before it.

It's closer in difficulty to Spaceman's trumpets which are most certainly not grown every round, and that's again still without any other mutational branching since Poppies only go to Lily then Trumpet.

@Colin-Tel
Copy link
Contributor

Revs are a royal pain and often just grief by spacing Evac and/or the entire station which is honestly a boring way to end a round.

To be honest with you, I would suggest that looking at what spawns a revenant and adjusting it so it isn't as often would be preferable compared to something that would alter the balance of glimmer as a whole.

@jimmy12or
Copy link
Contributor Author

Revs are a royal pain and often just grief by spacing Evac and/or the entire station which is honestly a boring way to end a round.

To be honest with you, I would suggest that looking at what spawns a revenant and adjusting it so it isn't as often would be preferable compared to something that would alter the balance of glimmer as a whole.

Because this isn't only about Revs really. It is to provide another potential use/"customer" for Botany along with allowing for the option of more stability. Almost every shift while playing Epi, I've had to either kill a genuinely GOOD anomaly or stop all research just because the glimmer had gotten close to being too high. Being able to lower glimmer isn't a bad thing, and again, it's not an easy thing to grow.

@Colin-Tel
Copy link
Contributor

The fact that it'd be possible to make 2 normality crystals with one Cosmic Revenant crop, seeing as it has a max ectoplasm of 10 per crop, just doesn't sit well with me.

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with Ectoplasm being present with the following changes made.

@jimmy12or
Copy link
Contributor Author

I would be fine with Ectoplasm being present with the following changes made.

Before I make changes, I would like to at least state that a fully robusted Cosmic Revenant pepper only actually produces 6u, likely due to the fact that 100 potency is nearly impossible and robust harvest only brings it up to 50.

I can change how much is in the spawnable version but I don't personally feel lowering the amount in the growable is needed.

@Colin-Tel Colin-Tel self-requested a review July 27, 2024 10:00
Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untouch RT lol

RobustToolbox Outdated Show resolved Hide resolved
@jimmy12or
Copy link
Contributor Author

untouch RT lol

I only removed the unneeded t from the word, what the heck happened here? Do you know what happened?

@Colin-Tel
Copy link
Contributor

I only removed the unneeded t from the word, what the heck happened here? Do you know what happened?

May want to revert your last commit, because it looks like you brought a submodule change onto the PR.

Alchebun added 3 commits July 27, 2024 03:09
@jimmy12or
Copy link
Contributor Author

I only removed the unneeded t from the word, what the heck happened here? Do you know what happened?

May want to revert your last commit, because it looks like you brought a submodule change onto the PR.

Still learning Git @_@

@Colin-Tel
Copy link
Contributor

image
try hitting this thing instead

…Revenant.rsi/meta.json

Co-authored-by: Colin-Tel <[email protected]>
Signed-off-by: Alchebun <[email protected]>
@jimmy12or
Copy link
Contributor Author

image try hitting this thing instead

Honestly, was worried that would make the CRLF check fail due to code being changed in Github rather than a standard commit. Glad that it doesn't.

@Colin-Tel Colin-Tel enabled auto-merge (squash) July 27, 2024 10:48
@Colin-Tel Colin-Tel merged commit 498534e into DeltaV-Station:master Jul 27, 2024
13 checks passed
@HandsomeTheEgg
Copy link

HandsomeTheEgg commented Aug 4, 2024

hey there , i know pr is closed but just wanted to leave some input , really liked the sprites and animation and ...dont understand the glimmer and ectoplasma stuff...but speaking of ectoplasma...another good usage would be if the ghost burger wouldnt require the item ectoplasma but like 5u of ectoplasma liquid , that way it also has another purpose instead of just epi , maybe for a future thing ( if the ectoplasma thing would be to hard you could also just make it like omnizine or koibeans 1-3u would tweak it a bit futher

@jimmy12or
Copy link
Contributor Author

hey there , i know pr is closed but just wanted to leave some input , really liked the sprites and animation and ...dont understand the glimmer and ectoplasma stuff...but speaking of ectoplasma...another good usage would be if the ghost burger wouldnt require the item ectoplasma but like 5u of ectoplasma liquid , that way it also has another purpose instead of just epi , maybe for a future thing ( if the ectoplasma thing would be to hard you could also just make it like omnizine or koibeans 1-3u would tweak it a bit futher

I feel this should be a pretty easy and straightforward change to make, I may see about doing that in the near future as a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants