checker: give an error for free method used by fixed arrays

Delta456 · Dec 31, 2023 · 95ece12 · 95ece12
1 parent b87586d
commit 95ece12
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/vlib/v/checker/fn.v b/vlib/v/checker/fn.v
@@ -1902,6 +1902,9 @@ fn (mut c Checker) method_call(mut node ast.CallExpr) ast.Type {
 				c.warn('manual memory management with `free()` is only allowed in unsafe code',
 					node.pos)
 			}
+			if left_sym.kind == .array_fixed {
+				c.error('unknown method or field: ${left_sym.name}.free()', node.pos)
+			}
 			return ast.void_type
 		}
 		// call struct field fn type

diff --git a/vlib/v/checker/tests/array_fixed_no_free_method_call_err.out b/vlib/v/checker/tests/array_fixed_no_free_method_call_err.out
@@ -0,0 +1,7 @@
+vlib/v/checker/tests/array_fixed_no_free_method_call_err.vv:5:19: error: unknown method or field: [24]u8.free()
+    3 |         `0`, `:`, `0`, `0`, `.`, `0`, `0`, `0`, `Z`]!
+    4 |     defer {
+    5 |         unsafe { buffer.free() }
+      |                         ~~~~~~
+    6 |     }
+    7 | }
diff --git a/vlib/v/checker/tests/array_fixed_no_free_method_call_err.vv b/vlib/v/checker/tests/array_fixed_no_free_method_call_err.vv
@@ -0,0 +1,7 @@
+fn main() {
+	mut buffer := [u8(`0`), `0`, `0`, `0`, `-`, `0`, `0`, `-`, `0`, `0`, `T`, `0`, `0`, `:`, `0`,
+		`0`, `:`, `0`, `0`, `.`, `0`, `0`, `0`, `Z`]!
+	defer {
+		unsafe { buffer.free() }
+	}
+}