Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pdbprep into codebase #592

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from
Draft

Conversation

DaniBodor
Copy link
Collaborator

@DaniBodor DaniBodor commented Mar 14, 2024

fixes #509

Work in progress.

Done so far:

  • Mimics functionality of all modules in pdbprep apart from the pairwise energy calculations.
  • Functionality currently split into 2 modules: preprocess and hydrogenation:
    • preprocess.py: combines do_pdbtools and do_pras from pdbprep, but using the full PyPi packages rather than using part of the codebase.
    • hydrogenation.py combines do_pdb2pqr, do_protonation, and do_add_hydrogens from pdbprep, but reformatted.
  • The 2 packages don't talk to each other yet, but only the top level function of each module exectutes all steps within that module.
  • Individual sequential steps until pdb2pqr have been visually tested in a notebook, but no formal tests are written (yet) for most of it.
  • Everything is scripted to run from within python. However, PRAS, PBD2PQR, and openmm work specifically with input and output files rather than being able to run on strings or otherwise from and to memory. For that reason, their functionalities are wrapped in TemporaryFile context managers, which are then converted to strings internally.
    • I believe this does not impact the file writing count on e.g. Snellius, but I am not positive of this

TO DO:

  • check some minor TODOs on code base with Joao
  • make the two modules talk to each other as well
  • add testing for each step + for the integrated functionality
  • add documentation for using this
  • add parallelization to speed up the process (?)
  • investigate whether file writing is counted towards limits on Snellius.
    • probably there is no way around it either way, but this is something that should be commented on in the docs.

If time left, but probably in separate PR:

  • investigate energy calculation integration into code base

@DaniBodor DaniBodor changed the base branch from main to dev March 14, 2024 22:40
@DaniBodor DaniBodor force-pushed the 509_integrate_pdbprep_dbodor branch from d07b0f1 to 6e708ac Compare March 19, 2024 13:50
Copy link

github-actions bot commented Apr 3, 2024

This PR is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale issue not touched from too much time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate PDBprep
1 participant