Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add action for testing the tutorials' notebooks #587

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Mar 4, 2024

No description provided.

@gcroci2 gcroci2 self-assigned this Mar 4, 2024
@gcroci2 gcroci2 changed the base branch from main to dev March 4, 2024 15:46
@gcroci2 gcroci2 linked an issue Mar 4, 2024 that may be closed by this pull request
@gcroci2 gcroci2 requested a review from DaniBodor March 4, 2024 16:06
Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think this is a really good addition.

If you fix the ignore on changes to notebooks thing (see inline comments), you can go ahead and merge.

.github/workflows/notebooks.yml Outdated Show resolved Hide resolved
.github/workflows/notebooks.yml Outdated Show resolved Hide resolved
@gcroci2 gcroci2 merged commit 887b129 into dev Mar 5, 2024
5 checks passed
@gcroci2 gcroci2 deleted the 576_add_ipynb_testing_gcroci2 branch March 5, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tutorials notebooks testing
2 participants