Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openMM to redefine the forcefield #393

Closed
DaniBodor opened this issue Mar 17, 2023 · 6 comments
Closed

Use openMM to redefine the forcefield #393

DaniBodor opened this issue Mar 17, 2023 · 6 comments
Assignees
Labels
covariates modules from the 'features' subpackage feature New feature to add needs info more information is needed priority Solve this first stale issue not touched from too much time

Comments

@DaniBodor
Copy link
Collaborator

This has multiple advantages:

  • allows optional (and correct) generation of hydrogens in pdb structures based on predicted protonation state
  • allows determining 1-3 and 1-4 pairings for nonbond energy calculation
  • more accurate/useful/?? forcefield?
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Apr 21, 2023
@gcroci2
Copy link
Collaborator

gcroci2 commented Nov 1, 2023

Following up on this after today's meeting, we decided to give high priority to modifying the package to be able to read in pdb files with hydrogens generated with @joaomcteixeira's code.

  • Did I understand correctly that you used amber forcefield instead of OPLS, the one we have in the deeprank2 package @joaomcteixeira?
  • If yes, isn't it possible to change the openMM parameter to the OPLS forcefield, so that then we're aligned with the package?

Also, @LilySnow asked to use @joaomcteixeira's code to calculate pairwise energies such as electrostatic and van der waals after we updated the forcefield. Reflecting on it now, to me it's not clear why is this needed, since we've already these features. For sure I'd need more context.

@gcroci2
Copy link
Collaborator

gcroci2 commented Nov 2, 2023

Following up on this after today's meeting, we decided to give high priority to modifying the package to be able to read in pdb files with hydrogens generated with @joaomcteixeira's code.

  • Did I understand correctly that you used amber forcefield instead of OPLS, the one we have in the deeprank2 package @joaomcteixeira?

OPLS is old, so it's recommended to replace it

@gcroci2
Copy link
Collaborator

gcroci2 commented Nov 2, 2023

Also, @LilySnow asked to use @joaomcteixeira's code to calculate pairwise energies such as electrostatic and van der waals after we updated the forcefield. Reflecting on it now, to me it's not clear why is this needed, since we've already these features. For sure I'd need more context.

We need Joao's code because we will not use anymore the param file for vdw, but we will use OpenMM directly for computing pair-wise energies. See this PR DeepRank/pdbprep#12

@joaomcteixeira
Copy link

Hi,

Yes, all the code I did is in the https://github.com/DeepRank/pdbprep repository.

Regarding interface atom-atom pairwise energy calculation using OpenMM it is all in the DeepRank/pdbprep#12, as you mentioned. Let me know if something is not clear in the documentation of the code or the code itself.

Best wishes,

@gcroci2
Copy link
Collaborator

gcroci2 commented Jun 27, 2024

This is done in pdbprep repository, but deeprank2 still uses OPLS forcefield without OpenMM. Integration of this into deeprank2 will be handled by #509

@gcroci2 gcroci2 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@gcroci2 gcroci2 reopened this Jun 27, 2024
@gcroci2 gcroci2 closed this as completed Jun 27, 2024
@gcroci2 gcroci2 moved this to Done in Development Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
covariates modules from the 'features' subpackage feature New feature to add needs info more information is needed priority Solve this first stale issue not touched from too much time
Projects
Status: Done
Development

No branches or pull requests

3 participants