Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydrogens unkown to the forcefield #380

Closed
Max1461 opened this issue Mar 8, 2023 · 3 comments
Closed

Fix hydrogens unkown to the forcefield #380

Max1461 opened this issue Mar 8, 2023 · 3 comments
Labels
bug Something isn't working stale issue not touched from too much time

Comments

@Max1461
Copy link

Max1461 commented Mar 8, 2023

@LilySnow @gcroci2 @DaniBodor
I run into a situation that when I use queries.process() to make and save my graph(s) the following type of warning messages are printed for several hydrogens atoms:

is unknown to the forcefield; charge is set to 0.0
is unknown to the forcefield; vanderwaals_parameters set to (0.0, 0.0, 0.0, 0.0)

The test situation in which this occurs is when I use the following pdb file(I have changed the extension otherwise I could not upload it to git)
1AKJ.txt

The hydrogen atoms are then added to this pdb file using:

reduce -FLIP -Quiet $pdbFL > $pdbFL.reduce_flip

Resulting in the following pdb file with hydrogens present:
1AKJ.txt

From this pdb file with added hydrogens a micro-environment is selected and written to a new pdb file, in this case:
1AKJ_1_ILE.txt

This pdb structure is added to
queries = QueryCollection()

And the graph is then generated and saved with

queries.process()

During the process step the warning message is printed, which i have added in the following text file:
warning_message.txt

This occurs because the hydrogen naming conventions in the pdb that has the hydrogens added through reduce do not match the hydrogen naming conventions present in the forcefield topology file used by DeepRank core.

I have already discussed this issue today during a meeting with @LilySnow and have made this issue after this. Hopefully I have provided enough information through the files, and if not I would gladly help out further.

@Max1461 Max1461 added the bug Something isn't working label Mar 8, 2023
@gcroci2 gcroci2 changed the title Bug: hydrogen is unknown to the forcefield Hydrogen is unknown to the forcefield Mar 9, 2023
@gcroci2 gcroci2 changed the title Hydrogen is unknown to the forcefield Fix hydrogens unkown to the forcefield Mar 9, 2023
@gcroci2
Copy link
Collaborator

gcroci2 commented Mar 9, 2023

Many thanks @Max1461, we'll look soon further into this :)

@DaniBodor
Copy link
Collaborator

I believe that this will be dealt with in #393

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Apr 24, 2023
@gcroci2 gcroci2 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@gcroci2 gcroci2 moved this to Done in Development Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale issue not touched from too much time
Projects
Status: Done
Development

No branches or pull requests

3 participants