Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gradle-notests #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

FriedLongJohns
Copy link
Contributor

build but without tests

@CoolSpy3
Copy link
Member

I'm not sure if it makes sense to merge this into master. Ideally, everything in master should build and pass tests. If both of those criteria are not met, the code should remain on a feature-branch. Both of those conditions are already checked by the Java CI test.

@FriedLongJohns
Copy link
Contributor Author

I think it makes sense to add this as a bit of ease for understanding. When you submit PRs, you can then very quickly see if the code or the tests are not working and quickly debug. The normal solution is to open the failed builds and read the errors which is valid but an alternative others do not always prefer.

I don't think it adds any bloat, given we only have 3 workflows total.

It adds extra functionality - if very little - to lib199 GitHub, but does not pose any significant problems in return.

@CoolSpy3
Copy link
Member

Both of those error conditions should be visible in the ide. Imo, separating the build and test phases only makes sense when working with a more complex test-set than what we have here. That being said, if you think this is valuable, I agree that the downsides aren't too excessive. At the very least, however, I think it might be better to merge all of these into the Java CI file. Either as two jobs or by splitting the build step into a separate build and test step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants