Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial changes for updated triton-viz #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danikhan632
Copy link

this is the initial commit for triton-viz

alot of this code may seem unused, but currently working features to add

as of right now 3 ops are visualized but looking to add more

@Jokeren
Copy link
Member

Jokeren commented Aug 7, 2024

Is it ready for review or still pending?

@danikhan632
Copy link
Author

still pending but does build and works missing features though

mainly want this function reviewed since it feels a bit hacky and will only really allow for contiguous loads/stores

other than that looking for any input but still needs a bit more work before being ready for merging

@danikhan632 danikhan632 marked this pull request as draft August 7, 2024 14:27
@Jokeren
Copy link
Member

Jokeren commented Aug 7, 2024

Got it. I'll probably be available at the end of this month to review the PR. No rush

@danikhan632 danikhan632 marked this pull request as ready for review September 24, 2024 02:34
@Jokeren
Copy link
Member

Jokeren commented Sep 24, 2024

Thanks!

Please do the following before I start reviewing the PR:

  1. Resolve conflicts
  2. Run pre-commit

@Jokeren
Copy link
Member

Jokeren commented Sep 24, 2024

@mark14wu Can you try to build this branch and play around some examples? If there's any issue, please report

@danikhan632 danikhan632 force-pushed the animation branch 3 times, most recently from a092307 to b9affd6 Compare September 25, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants