Fix test and remove useless function

DeebotUniverse · Jan 21, 2025 · 8fbd644 · 8fbd644
1 parent 8b27eb1
commit 8fbd644
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/deebot_client/map.py b/deebot_client/map.py
@@ -383,10 +383,6 @@ async def on_map_subset(event: MapSubsetEvent) -> None:
 
     # ---------------------------- METHODS ----------------------------
 
-    def _update_trace_points(self, data: str) -> None:
-        _LOGGER.debug("[_update_trace_points]: %s", data)
-        self._map_data.trace_values.extend(extract_trace_points(data))
-
     def _draw_map_pieces(self, image: Image.Image) -> None:
         _LOGGER.debug("[_draw_map_pieces] Draw")
         image_x = 0
@@ -467,7 +463,7 @@ async def on_map_trace(event: MapTraceEvent) -> None:
             if event.start == 0:
                 self._map_data.trace_values.clear()
 
-            self._update_trace_points(event.data)
+            self._map_data.trace_values.extend(extract_trace_points(event.data))
 
         unsubscribers.append(self._event_bus.subscribe(MapTraceEvent, on_map_trace))
 

diff --git a/tests/test_map.py b/tests/test_map.py
@@ -2,7 +2,7 @@
 
 import asyncio
 from typing import TYPE_CHECKING
-from unittest.mock import ANY, AsyncMock, Mock, call, patch
+from unittest.mock import ANY, AsyncMock, Mock, call
 
 import pytest
 from svg import (
@@ -40,7 +40,6 @@
     MapData,
     Path,
     Point,
-    TracePoint,
     ViewBoxFloat,
     _calc_point,
     _calc_point_in_viewbox,
@@ -49,6 +48,7 @@
     _points_to_svg_path,
 )
 from deebot_client.models import Room
+from deebot_client.rs import TracePoint
 
 from .common import block_till_done
 
@@ -186,10 +186,6 @@ async def on_change() -> None:
     assert not map._unsubscribers
 
 
-@patch(
-    "deebot_client.map.decompress_7z_base64_data",
-    Mock(return_value=b"\x10\x00\x00\x01\x00"),
-)
 async def test_Map_svg_traces_path(
     execute_mock: AsyncMock, event_bus_mock: Mock
 ) -> None:
@@ -198,7 +194,8 @@ async def test_Map_svg_traces_path(
     path = map._get_svg_traces_path()
     assert path is None
 
-    map._update_trace_points("")
+    # Normally trace points would be added by MapTraceEvent
+    map._map_data.trace_values.append(TracePoint(x=16, y=256, connected=True))
     path = map._get_svg_traces_path()
 
     assert path == Path(