feature/payment: update webhook for verify url

Deco-Team · May 5, 2024 · fd618ba · fd618ba
1 parent 1b68e8c
commit fd618ba
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/main.ts b/src/main.ts
@@ -77,7 +77,7 @@ async function bootstrap() {
   }
 
   // Example: process.env.CORS_VALID_ORIGINS=localhost,ngrok-free => parse to [ /localhost/, /ngrok-free/ ]
-  const origins = process.env.CORS_VALID_ORIGINS.split(',').map((origin) => new RegExp(origin)) || [
+  const origins = process.env.CORS_VALID_ORIGINS?.split(',').map((origin) => new RegExp(origin)) || [
     /localhost/,
     /ngrok-free/
   ]

diff --git a/src/payment/controllers/payment.controller.ts b/src/payment/controllers/payment.controller.ts
@@ -42,7 +42,7 @@ export class PaymentController {
     //1. Validate signature with other data
     const result = this.paymentService.verifyPaymentWebhookData(momoPaymentResponseDto)
     if (!result) return false
-    
+
     //2. Process webhook
     return this.paymentService.processWebhook(PaymentMethod.MOMO, momoPaymentResponseDto)
   }
@@ -55,13 +55,13 @@ export class PaymentController {
     console.log('Handling PAYOS webhook', JSON.stringify(webhookData))
     this.paymentService.setStrategy(PaymentMethod.PAY_OS)
 
+    // just skip for confirmWebhook
+    if (webhookData.data.orderCode == 123) return true
+
     //1. Validate signature with other data
     const result = this.paymentService.verifyPaymentWebhookData(webhookData)
     if (!result) return false
 
-    // // just skip for confirmWebhook
-    // if (webhookData.data.orderCode == 123) return true
-
     //2. Process webhook
     return this.paymentService.processWebhook(PaymentMethod.PAY_OS, webhookData)
   }
@@ -72,7 +72,7 @@ export class PaymentController {
   // @Post('webhook/payos-confirm')
   // async verifyWebhook() {
   //   console.log('Handling Confirm  Webhook URL for PAYOS')
-    
+
   //   await this.paymentService.payOSPaymentStrategy.verifyWebhookUrl()
   // }
 }