Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamline install #44

Merged
merged 11 commits into from
Oct 1, 2024
Merged

streamline install #44

merged 11 commits into from
Oct 1, 2024

Conversation

arcanez
Copy link
Contributor

@arcanez arcanez commented Sep 24, 2024

  • update modules
  • drastically simplify install
    • no more helm repos
    • use "mdai cluster" helm chart
    • use simple spinner and go func
  • decrease mdai binary size
  • use a flags struct for cobra commands

@arcanez arcanez self-assigned this Sep 24, 2024
weird-bytecode
weird-bytecode approved these changes Sep 24, 2024
View reviewed changes
Copy link

@weird-bytecode weird-bytecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but would like these conversations resolved before merge.

cmd/enable.go Show resolved Hide resolved
cmd/install.go Show resolved Hide resolved
cmd/install.go Show resolved Hide resolved
cmd/uninstall.go Show resolved Hide resolved
cmd/uninstall.go Show resolved Hide resolved
internal/helm/templates/mdai-cluster-values.yaml
manager:
collectorImage:
repository: otel/opentelemetry-collector-k8s
tag: 0.101.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rely on a default here, instead?

internal/helm/templates/prometheus-values.yaml Show resolved Hide resolved
@arcanez arcanez merged commit 233edbe into main Oct 1, 2024
6 checks passed
@arcanez arcanez deleted the streamline-install branch October 1, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin-Law Robin-Law Robin-Law approved these changes

@weird-bytecode weird-bytecode weird-bytecode approved these changes

@tsloughter tsloughter Awaiting requested review from tsloughter

@s0b01ev s0b01ev Awaiting requested review from s0b01ev

@o11yguru o11yguru Awaiting requested review from o11yguru

@o11ies o11ies Awaiting requested review from o11ies

Assignees

@arcanez arcanez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcanez @Robin-Law @weird-bytecode