Skip to content

Commit

Permalink
Merge branch 'reefscape' of github.com:Decatur-Robotics/Gearbox into …
Browse files Browse the repository at this point in the history
…reefscape
  • Loading branch information
renatodellosso committed Feb 13, 2025
2 parents ea4dd05 + 82845e7 commit d9c85db
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion components/forms/FieldPositionSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default function FieldPositionSelector({

useEffect(() => {
callback("AutoStart", { x: mx ?? 0, y: my ?? 0, angle: a ?? 0 });
}, [mx, my, a, ax, ay, callback]);
}, [mx, my, a, ax, ay, callback.name]);

Check warning on line 33 in components/forms/FieldPositionSelector.tsx

View workflow job for this annotation

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'callback'. Either include it or remove the dependency array. If 'callback' changes too often, find the parent component that defines it and wrap that definition in useCallback

const setup = (p5: p5Types, canvasParentRef: Element) => {
bg = p5.loadImage(
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sj3",
"version": "1.1.20",
"version": "1.2.0",
"private": true,
"repository": "https://github.com/Decatur-Robotics/Gearbox",
"license": "CC BY-NC-SA 4.0",
Expand Down

0 comments on commit d9c85db

Please sign in to comment.