Use node timers explicitly (for use with Electron) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the node timers are not explicitly set this library can't be used directly with the client side of Electron, when timers method are used explicitly Electron is able to recognize those and make them work on the client side.
|
@jpoppe What is the advantage of the Electron timers over the JavaScript standard? |
|
@jaller94 it is not about 'using electron timers' This pull requests explicitly imports (requires) the node timers module so setInterval will now be called with timers.setInterval. This will still be the same node timer (and nothing will change when this library is used with node), but without this require Electron is unable to determine that setInterval comes from node and would try to use the browser's built-in setInterval and would fail since it is incompatible (at least in this context). |
|
Thanks. I am not familiar with Electron development and got curious of why a library should adapt for one framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for more info.