Jiwon #2
Open
Jiwon #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejoyq
requested changes
Mar 17, 2023
There was a problem hiding this comment.
전체 package.json을 날리면 어떡해요!!
이러면 동작이 제대로 안됩니다....
There was a problem hiding this comment.
ㅈ..죄송합니다 ......... 모노레포는 처음이라 아무거나 만졌더니 ㅜㅜ
There was a problem hiding this comment.
root 에 package.json 만 롤백하면 되는건가요..?
There was a problem hiding this comment.
네 일단 그거 바꿔주시면 월요일에 볼게요 ㅎㅎㅎ 바빠서
bluejoyq
reviewed
Mar 21, 2023
There was a problem hiding this comment.
아직 완성되진 않았네요.
모든 컴포넌트에서 공통적으로 사용되는 함수에 대해서 분리한 부분이 참 좋은 것 같아요
bluejoyq
reviewed
Mar 21, 2023
| this.render() | ||
| return this; | ||
| } | ||
| setup(){} |
There was a problem hiding this comment.
이름이 set으로 시작하는 것 보다는 다른게 좋을 것 같아요.
setstate랑 헷갈림.
밑의 setEvent도 마찬가지에요!!
bluejoyq
reviewed
Mar 21, 2023
| ` | ||
| } | ||
| async fetchPhotos () { | ||
| const result = await fetch('/api/photos'); |
There was a problem hiding this comment.
이 부분 같은 경우 컴포넌트에서 다룰 부분이 아닌 것 같아요. 별도의 adapter와 port로 작성하는게 좋을 것 같네요(혹은 repository).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
뭔가 모종의 이유로 img 태그가 사진을 못불러오는데, 그 전까지의 기본적인 vanilla js 앱 컴포넌트를 만들어보았습니다.
바닐라로 클래스형 컴포넌트를 만드는거보는게 처음인데 재밌네요