Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: replace config.json with dotenv, pass config down from entry point #171

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Refactor: replace config.json with dotenv, pass config down from entry point #171

merged 5 commits into from
Feb 17, 2021

Conversation

kevinlul
Copy link
Contributor

Description

Remove most global side effects at module load. Will require a manual redeploy. The default colours could be externalized too. #161

Checklist

@kevinlul kevinlul requested a review from AlphaKretin February 12, 2021 16:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 561655999

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.833%
Totals Coverage Status
Change from base Build 556831081: 0.0%
Covered Lines: 892
Relevant Lines: 1113
💛 - Coveralls

AlphaKretin
AlphaKretin approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@AlphaKretin AlphaKretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe add ts-ignores above the non-null assertions in tests, but tests are a future concern anyway.

AlphaKretin
AlphaKretin requested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@AlphaKretin AlphaKretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised the README should be updated for the new envvars

@kevinlul kevinlul merged commit ec00470 into master Feb 17, 2021
@kevinlul kevinlul deleted the env branch February 17, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlphaKretin AlphaKretin AlphaKretin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinlul @coveralls @AlphaKretin