Merge pull request #928 from DavyJonesLocker/chore/fix-new-offenses

Fix safe performance offences
DavyJonesLocker · Dec 24, 2023 · a88662f · a88662f
2 parents c6ca746 + aeb56f0
commit a88662f
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
@@ -60,7 +60,6 @@ jobs:
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby-version }}
-        rubygems: latest
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake test:ruby

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -62,6 +62,10 @@ Metrics/PerceivedComplexity:
 Minitest/MultipleAssertions:
   Enabled: false
 
+# FIXME: DavyJonesLocker/client_side_validations#927
+Minitest/NonExecutableTestMethod:
+  Enabled: false
+
 Rails/ApplicationRecord:
   Exclude:
     - 'test/**/*'

diff --git a/lib/client_side_validations/extender.rb b/lib/client_side_validations/extender.rb
@@ -7,7 +7,7 @@ module Extender
     def extend(klass, validators)
       validators.each do |validator|
         require "client_side_validations/#{klass.underscore}/#{validator.downcase}"
-        const_get(klass)::Validations.const_get("#{validator}Validator").send :include, ClientSideValidations.const_get(klass).const_get(validator)
+        const_get(klass)::Validations.const_get(:"#{validator}Validator").send :include, ClientSideValidations.const_get(klass).const_get(validator)
       end
     end
   end

diff --git a/test/action_view/models/category.rb b/test/action_view/models/category.rb
@@ -12,7 +12,7 @@ class Category
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

diff --git a/test/action_view/models/comment.rb b/test/action_view/models/comment.rb
@@ -12,7 +12,7 @@ class Comment
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

diff --git a/test/action_view/models/format_thing.rb b/test/action_view/models/format_thing.rb
@@ -35,7 +35,7 @@ class FormatThing
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

diff --git a/test/action_view/models/post.rb b/test/action_view/models/post.rb
@@ -17,7 +17,7 @@ class Post
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

diff --git a/test/action_view/models/tag.rb b/test/action_view/models/tag.rb
@@ -10,7 +10,7 @@ class Tag
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end