-
Notifications
You must be signed in to change notification settings - Fork 1
Pull Request conventions
Pascal Röhling edited this page Dec 19, 2023
·
1 revision
- All threads have to be resolved before merging
- A thread is resolved by a Reviewer , not the Assignee
- An issue should be created and related information including the issue should be added as a comment if a thread should not be worked on as part of the PR
- Assignee and Reviewer clearly indicate to the other when their work is done
- This should be done with e.g. 🏓 @NAME for all the changes
- Procedural: The Reviewer can leave a thread to be closed by the Assignee with a 🎩
Optional:
- An Approve shall be given with 🚀 @NAME
made by developers with 🧊