Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent interference with Select extension #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mscdex
Copy link

@mscdex mscdex commented Nov 22, 2024

I'm not 100% of any potential negative side effects this could have, but I got tired of having Responsive (in inline control mode) toggling child rows every time I'd go to click on Select's checkbox for a row. This prevents that.

@AllanJard
Copy link
Contributor

Apologies for the delay in replying here. Interesting one this! This change gives Select the priority, but I wonder if Responsive should actually take priority?

That said, I would very much advocate that if Select and Responsive are being used together, then it would be a good idea to move the Responsive show/hide button into its own column and have Select not react on that column. I don't like the idea of a click on a single element triggering multiple actions (unless that is intentional of course!).

This Editor example shows Responsive, checkbox select and inline editing all operating together.

My current inclination is to keep the code as is, to encourage a separation of behaviour by the developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants