Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminating extra td elements in thead with 'left' or 'right' options #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacelys
Copy link

@jacelys jacelys commented Apr 30, 2014

Suppose that I have a table with two rows in thead. As far as I know, one suggested practice in this case is to use td elements in one row, like:

<thead>
    <tr class="col-nums">
        <td>1</td>
        <td>2</td>
        <td>3</td>
    </tr>
    <tr class="col-names">
        <th>Name1</th>
        <th>Name2</th>
        <th>Name3</th>
    </tr>
</thead>

Fixing the left or right two columns, for example, would be accomplished with:
new FixedHeader(table, {"left": 2});
new FixedHeader(table, {"right": 2});

Unfortunately, FixedHeader fails to remove the extra td elements in this case. The fix seems to be straightforward.

@DataTables
Copy link
Collaborator

It looks like there are actually quite a number of places where this error is occurring in the code. I need to look at it a bit closer and resolve this for all of the clone options.

I'm going to be releasing FixedHeader today in its current state, but I'll look into this when I can once the release process is done.

Thanks for flagging this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants