Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-140: Logging Enhancement #145

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Feature-140: Logging Enhancement #145

merged 12 commits into from
Oct 1, 2024

Conversation

doulikecookiedough
Copy link
Contributor

Summary of Changes:

  • Refactored logging statements to use logger instance instead of the logging library itself
  • Cleaned up logging statements in filehashstore module
  • Fixed bugs relating to potential dead lock issues where synchronization code was not called within a try block

@doulikecookiedough
Refactor the init process by declaring paralellization variables afte…
d35e9ac 
…r properties have been checked
@doulikecookiedough
Begin clean up logging statements by adding new method '_get_logger' …
dedd3a5 
…to get a logger instance for the 'filehashstore' module name and revise init process
@doulikecookiedough
Clean up code by renaming all 'exception_message' variables with 'err…
71827f5 
…_msg'
@doulikecookiedough
Clean-up logging in 'filehashstore' init related methods and delete r…
6180301 
…edundant method
@doulikecookiedough
Clean-up logging in 'filehashstore' interface methods and add missing…
692703b 
… logging messages in 'delete_object'
@doulikecookiedough
Fix bug in 'delete_object' where synchronization call was not made in…
47f6556 
… try block, and another bug where a cid was not locked during an exception scenario
@doulikecookiedough
Fix typo in logging message in '_synchronize_object_locked_pids'
f70243e
@doulikecookiedough
Clean-up logging in 'filehashstore' supporting and core methods part. 1
276c6e7
@doulikecookiedough
Refactor '_delete_object_only', add missing logging statements and fi…
d6c3c69 
…x potential dead lock due to sync being outside try block
@doulikecookiedough
Clean-up logging in 'filehashstore' remaining supporting and core met…
dbd57de 
…hods, and optimize sync method logging calls, add missing logging statements
@doulikecookiedough
Refactor and fix bug in 'store_object' where sync method was not with…
6256bcb 
…in try block which could lead to dead lock
@doulikecookiedough
Clean-up code/resolve linting errors for missed unused variables and …
fe5e7db 
…for long lines
@doulikecookiedough doulikecookiedough merged commit 0aa07b6 into develop Oct 1, 2024
2 checks passed
@doulikecookiedough doulikecookiedough mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doulikecookiedough