-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to polkadot latest version #241
base: make_compatible_with_kusama
Are you sure you want to change the base?
Conversation
impl WeightToFeePolynomial for WeightToFee { | ||
type Balance = Balance; | ||
fn polynomial() -> WeightToFeeCoefficients<Self::Balance> { | ||
// in Rococo, extrinsic base weight (smallest non-zero weight) is mapped to 1 MILLIUNIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you discussed these proposed values for p
and q
and WeightToFeeCoefficient
field values with the team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added details in shared sheet Runtime Upgrade Values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of storing them in an internal spreadsheet, could you please create a Github issue for each of the Runtime Upgrade Values that haven't been resolved.
ideally the comments associated with these Runtime Upgrade Values should be included as comments in the code so it appears in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised here #246
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i haven't tried running this, i've only reviewed the code and left comments.
if you think it's necessary for me to run it please share instructions
@ayushmishra2005 please DM me when you've responded to all the questions and made the linting changes so i can respond if necessary all at once |
Upgraded to polkadot 0.9.13
@ltfschoen I have tested it locally. Its working fine. However if you want to test, you can follow https://docs.substrate.io/tutorials/v3/cumulus/start-relay/ and replace |
No description provided.