Skip to content

Load diagram from URL #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Load diagram from URL #142

merged 1 commit into from
Jun 24, 2025

Conversation

Kr0nox
Copy link
Contributor

@Kr0nox Kr0nox commented Jun 3, 2025

Adds the ability to load a file from a url.

Syntax dataflowanalysis.github.io/WebEditor/?file=FILE_URL

@Kr0nox Kr0nox self-assigned this Jun 3, 2025
@Kr0nox Kr0nox requested a review from Nicolas-Boltz June 23, 2025 17:03
sebinside
sebinside approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future versions, we should discuss what to do if the loading fails, e.g., redirecting to the default diagram. For now, this is fine.

@sebinside sebinside removed the request for review from Nicolas-Boltz June 24, 2025 12:19
@sebinside sebinside merged commit 91e1950 into main Jun 24, 2025
3 checks passed
@sebinside sebinside deleted the load-from-url branch June 24, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside sebinside approved these changes

Assignees

@Kr0nox Kr0nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @sebinside