[PROF-11306] Fix crashtracking specs failing due to format change #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR fixes the crashtracking specs failing on https://github.com/Datadog/vaccine/actions/runs/13239150949 (from DataDog/dd-trace-rb#4353 ) due to the `additional_stacktraces` key no longer being included in the payload. Since I removed the assertion on the key, the updated test will work on both libdatadog < v16 as well as >= v16. **Motivation:** Unblock upgrade to libdatadog v16. **Additional Notes:** To get the "records", I needed to 1. Clone catadog, bundle install 2. mkdir records 3. bundle exec bin/catadog --record records --no-forward ...and then `kill -SEGV` a Ruby process that had dd-trace-rb loaded. This was enough for me: ```bash DD_TRACE_AGENT_PORT=8128 be ruby -e "require 'datadog'; Datadog.configure { }; sleep" ``` **How to test the change?** I've gathered the records from both libdatadog < v16 and v16 in https://gist.github.com/ivoanjo/52314e67602f2039bdcfe4ab869701b2 and used them to validate this change. By placing them into a directory, they can be validated as such: ```bash RECORDS_DIR=records-new/ bundle exec rspec spec/records_spec.rb ```
TonyCTHsu
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the crashtracking specs failing on
https://github.com/Datadog/vaccine/actions/runs/13239150949 (from DataDog/dd-trace-rb#4353 ) due to the
additional_stacktraceskey no longer being included in the payload.Since I removed the assertion on the key, the updated test will work on both libdatadog < v16 as well as >= v16.
Motivation:
Unblock upgrade to libdatadog v16.
Additional Notes:
To get the "records", I needed to
...and then
kill -SEGVa Ruby process that had dd-trace-rb loaded.This was enough for me:
DD_TRACE_AGENT_PORT=8128 be ruby -e "require 'datadog'; Datadog.configure { }; sleep"How to test the change?
I've gathered the records from both libdatadog < v16 and v16 in https://gist.github.com/ivoanjo/52314e67602f2039bdcfe4ab869701b2 and used them to validate this change.
By placing them into a directory, they can be validated as such:
RECORDS_DIR=records-new/ bundle exec rspec spec/records_spec.rb