allow for an SSH url to be used for github in update script for telemetry #3944
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bm1549
reviewed
Jan 30, 2025
| 2. Add config normalization rules [here](https://github.com/DataDog/dd-go/tree/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/) following the existing pattern | ||
| 1. This can be merged with any review from [@apm-sdk](https://github.com/orgs/DataDog/teams/apm-sdk) | ||
| 1. Check the test failure to see exactly which configs are missing. | ||
| 2. Add config normalization rules [here](https://github.com/DataDog/dd-go/tree/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/) following the existing pattern. Note that the PR must be made against the prod (default) branch. |
There was a problem hiding this comment.
Suggested change
| 2. Add config normalization rules [here](https://github.com/DataDog/dd-go/tree/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/) following the existing pattern. Note that the PR must be made against the prod (default) branch. | |
| 2. Add config normalization rules [here](https://github.com/DataDog/dd-go/tree/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/) following the existing pattern. Note that the PR should be made against the `prod` (default) branch. |
There was a problem hiding this comment.
While it normally should be made against the prod branch, there are valid use cases for doing it against a feature branch. As such, I'd prefer to loosen the language a bit here
| 2. Bonus Points: Run the auto-formatter [_format.py](https://github.com/DataDog/dd-go/blob/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/_format.py) from the `dd-go` root via `python ./trace/apps/tracer-telemetry-intake/telemetry-payload/static/_format.py` | ||
| 3. After merging, update system-tests by running [update.sh](/tests/telemetry_intake/update.sh) | ||
| 1. This can be run from the root by running `./tests/telemetry_intake/update.sh` | ||
| 1. This can be run from the root by running `./tests/telemetry_intake/update.sh` (You may need to set `USE_GIT_SSH=1` to force a `[email protected]:` URL) |
There was a problem hiding this comment.
Suggested change
| 1. This can be run from the root by running `./tests/telemetry_intake/update.sh` (You may need to set `USE_GIT_SSH=1` to force a `[email protected]:` URL) | |
| 1. This can be run from the root by running `./tests/telemetry_intake/update.sh` | |
| 1. If this fails, try re-running with `USE_GIT_SSH=1` to force a `[email protected]:` URL |
bm1549
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the http urls weren't working for me
Changes
see title
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present