Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Enable IP blocking tests for Ruby #3937

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 30, 2025

Motivation

We are now supporting IP Blocking in ruby with the full denylist.

Changes

This PR enables IP Blocking tests for Ruby.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Jan 30, 2025
@y9v y9v force-pushed the enable-ip-blocking-for-ruby branch 4 times, most recently from a069f3b to 88676bd Compare February 4, 2025 12:41
@y9v y9v changed the title Ruby: Enable IP blocking tests for Ruby [ruby] Enable IP blocking tests for Ruby Feb 5, 2025
@y9v y9v force-pushed the enable-ip-blocking-for-ruby branch from 944042d to eb41828 Compare February 5, 2025 15:44
@y9v y9v force-pushed the enable-ip-blocking-for-ruby branch from eb41828 to f21ed75 Compare February 5, 2025 15:45
@y9v y9v marked this pull request as ready for review February 5, 2025 16:07
@y9v y9v requested review from a team as code owners February 5, 2025 16:07
@y9v y9v merged commit 33fb903 into main Feb 6, 2025
74 checks passed
@y9v y9v deleted the enable-ip-blocking-for-ruby branch February 6, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants