[Debugger] Make source_file optional + make sure debugger controller exists in symbols
#3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shurivich
requested review from
emmettbutler,
tabgok,
jandro996,
sezen-datadog and
nayeem-kamal
and removed request for
a team
cbeauchesne
reviewed
Jan 30, 2025
| @@ -305,6 +305,9 @@ jobs: | |||
| - name: Run DEBUGGER_EXCEPTION_REPLAY scenario | |||
| if: always() && steps.build.outcome == 'success' && contains(inputs.scenarios, '"DEBUGGER_EXCEPTION_REPLAY"') | |||
| run: ./run.sh DEBUGGER_EXCEPTION_REPLAY | |||
| - name: Run DEBUGGER_SYMDB scenario | |||
There was a problem hiding this comment.
we forget to add it ? Oo
There was a problem hiding this comment.
Yes, we forgot to add it before 😞
cbeauchesne
requested changes
Jan 30, 2025
| self._assert_debugger_controller_exists() | ||
|
|
||
| def _assert_debugger_controller_exists(self): | ||
| pattern = r"[Dd]ebugger[_]?[Cc]ontroller" |
There was a problem hiding this comment.
If there is only one char in a char set, you can directly use the cahr
Suggested change
| pattern = r"[Dd]ebugger[_]?[Cc]ontroller" | |
| pattern = r"[Dd]ebugger_?[Cc]ontroller" |
There was a problem hiding this comment.
Underscore is optional. In python it's called debugger_controller, in java and dotnet - DebuggerController
There was a problem hiding this comment.
yep, the ? just after the _ will do the trick : https://regex101.com/r/J1P4r6/1
There was a problem hiding this comment.
Though, it's just a detail, feel free to ignore 😄
Co-authored-by: Charles de Beauchesne <[email protected]>
ojung
approved these changes
Jan 30, 2025
cbeauchesne
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make
source_fileoptional + make sure debugger controller exists in symbolsChanges
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present