[Tracing] Implement initial weblog tests for the runtime metrics feature #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing runtime metrics by observing what metrics the agent is sending to the backend
- Add Java weblog test skips - spring-boot-openliberty: Remove DD_JMXFETCH_ENABLED=false - spring-boot-wildfly: Set DD_APP_CUSTOMLOGMANAGER=true so that we can simultaneously enable JMXFetch and also let Wildfly set up its own java.util.logging backend. This allows the app server to succeed and the container to run, though it fails the tests.
zacharycmontoya
requested review from
Kyle-Verhoog,
christophe-papazian,
manuel-alvarez-alvarez,
ValentinZakharov and
cataphract
and removed request for
a team
link04
approved these changes
Jan 29, 2025
zacharycmontoya
force-pushed
the
zach.montoya/weblog/runtime-metrics-tests
branch
from
a788150 to
d69f9df
Compare
zacharycmontoya
force-pushed
the
zach.montoya/weblog/runtime-metrics-tests
branch
from
e379217 to
8b68daf
Compare
cbeauchesne
requested changes
Jan 30, 2025
mcculls
reviewed
Jan 30, 2025
…ument the reason for the DD_DOGSTATSD_START_DELAY=0 configuration.
cbeauchesne
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"dogstatsd_non_local_traffic: true" to the agent image and start testing runtime metrics by observing what metrics the agent is sending to the backend
Motivation
We need to assert some basic functionalities of the Runtime Metrics feature across various tracing libraries.
Changes
dogstatsd_non_local_traffic: trueto the Datadog agent container/api/v2/seriesbackend APITest_Config_RuntimeMetrics_EnabledandTest_Config_RuntimeMetrics_Enabled_WithRuntimeId. Each test case hits an endpoint, waits 10s (that is the default interval for submitting runtime metrics), and asserts properties of the submitted metricsThe end result is that the .NET Tracer and the Java Tracer are fully passing the initial tests
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present