Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DSM nodeJS tests for RabbitMQ #3346

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

piochelepiotr
Copy link
Contributor

Motivation

NodeJS in rabbitMQ was not getting the queue name correctly. It was using the routing key instead.
Update the tests to match the other languages.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@piochelepiotr piochelepiotr requested a review from a team as a code owner October 30, 2024 16:06
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing on modified test method

@piochelepiotr
Copy link
Contributor Author

It's failing on modified test method

Yes, it's because the test is actually testing the wrong behavior. We want the queue name in the topic field, not the routing key.
It goes with this change:
DataDog/dd-trace-js#4839

I think I still need to merge this update to tests before I can merge the dd-trace-js method?

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, feel free to merge this one in first, as long as the second one is merge soon after 😉

@piochelepiotr piochelepiotr merged commit 86596aa into main Nov 1, 2024
290 of 292 checks passed
@piochelepiotr piochelepiotr deleted the piotr-wolski/update-node-js-test branch November 1, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants