Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add phpdocs for constructor config #153

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Jul 28, 2024

Small improvement that will enable phpstorm and other support which is typing out the array parameters aka. keys with its expected type value. Also the disable_telemetry parameter was missing. I don't find constructor values listed honestly, but kept it just for the BC

@Ferror Ferror requested a review from a team as a code owner July 28, 2024 16:36
Copy link
Contributor

@vickenty vickenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@vickenty vickenty merged commit c2c7889 into DataDog:master Jul 29, 2024
10 checks passed
@Ferror Ferror deleted the phpdoc-improvement branch July 31, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants