Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aj/honor metric timestamps #904

Merged
merged 15 commits into from
Feb 28, 2025
Merged

Aj/honor metric timestamps #904

merged 15 commits into from
Feb 28, 2025

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Feb 28, 2025

What does this PR do?

Originally the tiny statsd impl here would rely on flush cadence to determine metric aggregation. We'd like to expand that now, so we need to add a ten-second window to the hash key in order to aggregate by the window as well as metric context.

At the same time I saw the opportunity to add support for custom metric timestamps, so I implemented that as well.

Motivation

More capabilities

How to test the change?

Automated tests here along with self monitoring tests for acceptance

@astuyve astuyve requested a review from a team as a code owner February 28, 2025 13:58
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-02-28 21:19:51

Comparing candidate commit bec02bd in PR branch aj/honor-metric-timestamps with baseline commit eae5885 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.213µs 3.187µs ± 1.523µs 2.983µs ± 0.024µs 3.006µs 3.593µs 13.860µs 17.075µs 472.47% 7.647 59.820 47.68% 0.108µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.976µs; 3.398µs] or [-6.624%; +6.624%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.578ns 253.674ns ± 11.910ns 248.047ns ± 2.545ns 255.617ns 284.238ns 292.764ns 293.429ns 18.30% 1.845 2.644 4.68% 0.842ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.023ns; 255.325ns] or [-0.651%; +0.651%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.627µs 209.081µs ± 0.179µs 209.081µs ± 0.117µs 209.203µs 209.373µs 209.454µs 209.585µs 0.24% -0.070 -0.124 0.09% 0.013µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4771333.194op/s 4782828.719op/s ± 4096.175op/s 4782840.444op/s ± 2667.267op/s 4785459.382op/s 4789139.637op/s 4792529.496op/s 4793245.359op/s 0.22% 0.075 -0.123 0.09% 289.643op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.238µs 18.317µs ± 0.028µs 18.315µs ± 0.014µs 18.334µs 18.360µs 18.386µs 18.419µs 0.57% 0.219 0.787 0.15% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54290946.551op/s 54594758.658op/s ± 84318.564op/s 54601445.015op/s ± 42932.270op/s 54638937.635op/s 54735243.672op/s 54781732.465op/s 54831836.747op/s 0.42% -0.207 0.775 0.15% 5962.223op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.658µs 10.711µs ± 0.032µs 10.703µs ± 0.023µs 10.735µs 10.770µs 10.783µs 10.826µs 1.14% 0.598 -0.013 0.30% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92370482.373op/s 93364315.720op/s ± 277418.505op/s 93428122.159op/s ± 202040.288op/s 93564052.726op/s 93761779.957op/s 93801017.667op/s 93826572.407op/s 0.43% -0.584 -0.046 0.30% 19616.451op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.057µs; 209.106µs] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4782261.028op/s; 4783396.409op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.313µs; 18.321µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54583072.916op/s; 54606444.400op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.706µs; 10.715µs] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/good throughput [93325868.183op/s; 93402763.257op/s] or [-0.041%; +0.041%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.101µs 33.876µs ± 0.960µs 33.293µs ± 0.069µs 34.870µs 35.630µs 35.793µs 36.475µs 9.56% 1.017 -0.758 2.83% 0.068µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.743µs; 34.009µs] or [-0.393%; +0.393%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.532µs 505.597µs ± 0.429µs 505.552µs ± 0.206µs 505.785µs 506.141µs 506.313µs 509.520µs 0.78% 3.664 33.441 0.08% 0.030µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1962632.780op/s 1977860.289op/s ± 1673.842op/s 1978037.302op/s ± 805.891op/s 1978605.993op/s 1980107.826op/s 1981326.283op/s 1982034.182op/s 0.20% -3.608 32.823 0.08% 118.358op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.316µs 453.278µs ± 0.322µs 453.258µs ± 0.202µs 453.482µs 453.749µs 454.159µs 454.426µs 0.26% 0.326 0.800 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2200578.796op/s 2206154.587op/s ± 1568.935op/s 2206246.789op/s ± 981.951op/s 2207159.523op/s 2208746.000op/s 2209290.021op/s 2210841.791op/s 0.21% -0.320 0.793 0.07% 110.940op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 176.113µs 176.846µs ± 0.255µs 176.902µs ± 0.160µs 177.006µs 177.215µs 177.382µs 177.465µs 0.32% -0.512 0.270 0.14% 0.018µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5634924.769op/s 5654660.264op/s ± 8169.649op/s 5652838.766op/s ± 5102.202op/s 5660560.096op/s 5668408.963op/s 5676443.829op/s 5678178.828op/s 0.45% 0.520 0.280 0.14% 577.681op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.520µs 37.630µs ± 0.045µs 37.628µs ± 0.028µs 37.658µs 37.712µs 37.734µs 37.797µs 0.45% 0.344 0.557 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26457264.596op/s 26574769.134op/s ± 31599.562op/s 26575808.305op/s ± 19781.385op/s 26594899.609op/s 26622359.845op/s 26646061.784op/s 26652439.636op/s 0.29% -0.335 0.544 0.12% 2234.426op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.087µs 48.309µs ± 0.254µs 48.107µs ± 0.018µs 48.541µs 48.621µs 48.775µs 49.951µs 3.83% 1.531 6.634 0.52% 0.018µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20019641.248op/s 20700763.265op/s ± 108089.657op/s 20786796.231op/s ± 7578.606op/s 20791722.518op/s 20792821.368op/s 20793869.588op/s 20795508.170op/s 0.04% -1.436 5.819 0.52% 7643.093op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.538µs; 505.657µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977628.311op/s; 1978092.267op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.233µs; 453.322µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205937.148op/s; 2206372.026op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.810µs; 176.881µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5653528.029op/s; 5655792.498op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.624µs; 37.636µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26570389.739op/s; 26579148.529op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.273µs; 48.344µs] or [-0.073%; +0.073%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20685783.078op/s; 20715743.452op/s] or [-0.072%; +0.072%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.746µs 25.626µs ± 11.287µs 17.902µs ± 0.100µs 35.237µs 43.638µs 54.935µs 99.392µs 455.19% 2.174 9.117 43.93% 0.798µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.061µs; 27.190µs] or [-6.104%; +6.104%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.358µs 2.395µs ± 0.011µs 2.397µs ± 0.006µs 2.402µs 2.411µs 2.416µs 2.457µs 2.52% -0.020 4.633 0.48% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.394µs; 2.397µs] or [-0.067%; +0.067%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 54.358ms 54.871ms ± 0.212ms 54.832ms ± 0.077ms 54.939ms 55.210ms 55.435ms 56.414ms 2.88% 2.096 13.755 0.39% 0.015ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.842ms; 54.901ms] or [-0.054%; +0.054%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.994ms 6.005ms ± 0.004ms 6.005ms ± 0.003ms 6.007ms 6.011ms 6.015ms 6.017ms 0.20% 0.057 0.199 0.07% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.004ms; 6.005ms] or [-0.009%; +0.009%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.917µs 3.919µs 0.15% -2.091 10.941 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255157578.530op/s 255544357.208op/s ± 180353.148op/s 255528248.659op/s ± 84514.916op/s 255597695.830op/s 255892154.758op/s 255983086.166op/s 256804799.506op/s 0.50% 2.109 11.095 0.07% 12752.893op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 82.132µs 82.403µs ± 0.226µs 82.324µs ± 0.076µs 82.471µs 82.833µs 83.158µs 83.666µs 1.63% 2.161 6.179 0.27% 0.016µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11952245.489op/s 12135574.240op/s ± 33062.374op/s 12147095.149op/s ± 11203.510op/s 12154799.038op/s 12167121.578op/s 12172109.255op/s 12175494.382op/s 0.23% -2.132 5.984 0.27% 2337.863op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.516µs 77.016µs ± 0.309µs 76.980µs ± 0.183µs 77.170µs 77.533µs 77.810µs 78.981µs 2.60% 1.900 8.280 0.40% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12661324.756op/s 12984569.104op/s ± 51641.423op/s 12990463.704op/s ± 30927.841op/s 13020955.928op/s 13046610.190op/s 13066045.423op/s 13069083.174op/s 0.61% -1.822 7.705 0.40% 3651.600op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.919µs 3.921µs 0.20% -1.512 9.413 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255013867.065op/s 255516460.188op/s ± 187786.756op/s 255519508.924op/s ± 87687.874op/s 255598271.146op/s 255821358.961op/s 255939688.615op/s 256779661.443op/s 0.49% 1.532 9.556 0.07% 13278.529op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.796µs 73.864µs ± 0.455µs 73.859µs ± 0.325µs 74.157µs 74.601µs 75.012µs 75.101µs 1.68% 0.292 -0.305 0.61% 0.032µs 1 200
credit_card/is_card_number/378282246310005 throughput 13315486.665op/s 13538858.581op/s ± 83325.351op/s 13539372.046op/s ± 59884.097op/s 13603411.738op/s 13657838.969op/s 13701187.122op/s 13736985.217op/s 1.46% -0.263 -0.330 0.61% 5891.992op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.978µs 52.209µs ± 0.108µs 52.209µs ± 0.072µs 52.267µs 52.402µs 52.478µs 52.655µs 0.85% 0.560 0.765 0.21% 0.008µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18991601.360op/s 19153759.114op/s ± 39595.347op/s 19153965.361op/s ± 26313.790op/s 19185082.162op/s 19211676.474op/s 19227816.133op/s 19238739.125op/s 0.44% -0.545 0.726 0.21% 2799.814op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.514µs 6.659µs ± 0.058µs 6.671µs ± 0.039µs 6.701µs 6.740µs 6.763µs 6.816µs 2.17% -0.388 -0.081 0.87% 0.004µs 1 200
credit_card/is_card_number/x371413321323331 throughput 146722666.631op/s 150192504.408op/s ± 1307519.821op/s 149908820.431op/s ± 866937.340op/s 150883954.863op/s 152614168.276op/s 153408497.371op/s 153519456.523op/s 2.41% 0.434 -0.065 0.87% 92455.613op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.928µs 0.35% -1.411 13.339 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254610659.361op/s 255514198.104op/s ± 195341.793op/s 255496306.824op/s ± 84829.121op/s 255591527.159op/s 255830276.670op/s 255929783.954op/s 256898312.693op/s 0.55% 1.442 13.505 0.08% 13812.751op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.652µs 63.877µs ± 0.126µs 63.844µs ± 0.051µs 63.909µs 64.206µs 64.303µs 64.378µs 0.84% 1.822 3.748 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15533307.418op/s 15655188.127op/s ± 30827.187op/s 15663084.484op/s ± 12400.625op/s 15673220.736op/s 15688597.371op/s 15698709.084op/s 15710478.889op/s 0.30% -1.807 3.696 0.20% 2179.811op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.638µs 57.740µs ± 0.070µs 57.722µs ± 0.027µs 57.758µs 57.850µs 58.062µs 58.190µs 0.81% 3.093 14.024 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17185025.640op/s 17318997.002op/s ± 21017.254op/s 17324309.227op/s ± 8116.843op/s 17331406.625op/s 17336810.706op/s 17348188.750op/s 17349554.436op/s 0.15% -3.069 13.838 0.12% 1486.144op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.897µs 3.914µs ± 0.004µs 3.914µs ± 0.002µs 3.916µs 3.919µs 3.922µs 3.931µs 0.43% -0.234 4.647 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254401119.445op/s 255483081.899op/s ± 232461.247op/s 255483300.332op/s ± 105446.861op/s 255576098.430op/s 255861778.059op/s 256037300.478op/s 256632245.389op/s 0.45% 0.252 4.655 0.09% 16437.492op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.544µs 54.714µs ± 0.167µs 54.658µs ± 0.023µs 54.689µs 55.104µs 55.279µs 55.744µs 1.99% 2.961 10.017 0.30% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17939013.237op/s 18277126.900op/s ± 55252.808op/s 18295467.298op/s ± 7605.866op/s 18300910.013op/s 18314280.194op/s 18329155.073op/s 18333666.111op/s 0.21% -2.932 9.750 0.30% 3906.964op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.931µs 52.248µs ± 0.125µs 52.241µs ± 0.092µs 52.344µs 52.452µs 52.484µs 52.498µs 0.49% -0.103 -0.616 0.24% 0.009µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19048337.140op/s 19139553.995op/s ± 45905.229op/s 19141874.741op/s ± 33545.040op/s 19169809.946op/s 19212425.944op/s 19246705.060op/s 19256498.567op/s 0.60% 0.113 -0.609 0.24% 3245.990op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.461µs 6.639µs ± 0.063µs 6.642µs ± 0.043µs 6.682µs 6.728µs 6.759µs 6.802µs 2.42% -0.290 -0.277 0.95% 0.004µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 147009447.605op/s 150642797.530op/s ± 1443249.657op/s 150565072.986op/s ± 979268.520op/s 151566471.314op/s 153373158.416op/s 153773974.189op/s 154764338.880op/s 2.79% 0.337 -0.249 0.96% 102053.162op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255519361.996op/s; 255569352.420op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.372µs; 82.434µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12130992.113op/s; 12140156.367op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.973µs; 77.058µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12977412.099op/s; 12991726.108op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255490434.750op/s; 255542485.627op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.801µs; 73.927µs] or [-0.085%; +0.085%] None None None
credit_card/is_card_number/378282246310005 throughput [13527310.489op/s; 13550406.674op/s] or [-0.085%; +0.085%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.194µs; 52.224µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19148271.580op/s; 19159246.648op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.651µs; 6.667µs] or [-0.120%; +0.120%] None None None
credit_card/is_card_number/x371413321323331 throughput [150011294.736op/s; 150373714.080op/s] or [-0.121%; +0.121%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255487125.610op/s; 255541270.598op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.859µs; 63.894µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15650915.776op/s; 15659460.479op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.730µs; 57.750µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17316084.212op/s; 17321909.791op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.915µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255450865.006op/s; 255515298.793op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.691µs; 54.737µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18269469.392op/s; 18284784.408op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.231µs; 52.265µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19133191.971op/s; 19145916.018op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.630µs; 6.648µs] or [-0.132%; +0.132%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [150442777.008op/s; 150842818.052op/s] or [-0.133%; +0.133%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.509µs 67.781µs ± 0.320µs 67.742µs ± 0.070µs 67.825µs 67.976µs 68.368µs 71.817µs 6.01% 10.311 125.644 0.47% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.736µs; 67.825µs] or [-0.065%; +0.065%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.940µs 5.016µs ± 0.058µs 4.992µs ± 0.035µs 5.078µs 5.106µs 5.107µs 5.110µs 2.36% 0.449 -1.437 1.14% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.008µs; 5.024µs] or [-0.159%; +0.159%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bec02bd 1740776908 aj/honor-metric-timestamps
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.599µs 150.844µs ± 0.309µs 150.810µs ± 0.139µs 150.956µs 151.325µs 151.657µs 152.521µs 1.13% 0.953 6.834 0.20% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.801µs; 150.887µs] or [-0.028%; +0.028%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 87.91946% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.79%. Comparing base (eae5885) to head (bec02bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files         328      328           
  Lines       48712    48807   +95     
=======================================
+ Hits        34972    35041   +69     
- Misses      13740    13766   +26     
Components Coverage Δ
crashtracker 42.90% <ø> (ø)
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.21% <ø> (ø)
data-pipeline-ffi 90.39% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (+0.14%) ⬆️
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <87.91%> (-0.43%) ⬇️
dogstatsd-client 82.57% <ø> (ø)
ipc 82.63% <ø> (ø)
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.23% <ø> (ø)
sidecar-ffi 0.14% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 92.00% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 93.29% <ø> (ø)

@astuyve astuyve enabled auto-merge (squash) February 28, 2025 19:27
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved – remove the println

@astuyve astuyve merged commit 89754a9 into main Feb 28, 2025
31 checks passed
@astuyve astuyve deleted the aj/honor-metric-timestamps branch February 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants