feat(dogstatsd): compress metrics #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
==========================================
+ Coverage 71.76% 71.77% +0.01%
==========================================
Files 328 328
Lines 48702 48712 +10
==========================================
+ Hits 34949 34962 +13
+ Misses 13753 13750 -3
|
BenchmarksComparisonBenchmark execution time: 2025-02-27 19:00:14 Comparing candidate commit 0c80cbe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
morrisonlevi
force-pushed
the
aj/compress-metrics
branch
from
4da472c to
9153b45
Compare
morrisonlevi
force-pushed
the
aj/compress-metrics
branch
from
9153b45 to
2c7bb8e
Compare
| @@ -25,6 +25,7 @@ tokio = { version = "1.37.0", default-features = false, features = ["macros", "r | |||
| tokio-util = { version = "0.7.11", default-features = false } | |||
| tracing = { version = "0.1.40", default-features = false } | |||
| regex = { version = "1.10.6", default-features = false } | |||
| zstd = { version = "0.13.3", default-features = false } | |||
There was a problem hiding this comment.
should we use gzip or zstd for both logs and metrics? To avoid adding 2 libs?
There was a problem hiding this comment.
We use zstd for both
There was a problem hiding this comment.
morrisonlevi
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses zstd for dogstatsd. Not optional, always enabled.
Motivation
should help a small bit with network bytes:
