-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-11306] Package libdatadog v16.0.1 for Ruby #864
Conversation
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v16.0.1. Of particular interest, this includes improvements to crashtracking and the managed string table needed by DataDog/dd-trace-rb#4331 . **Additional Notes:** N/A **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#4353 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
BenchmarksComparisonBenchmark execution time: 2025-02-10 09:48:06 Comparing candidate commit 00dea93 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 48 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 71.92% 71.98% +0.05%
==========================================
Files 323 323
Lines 48086 48086
==========================================
+ Hits 34588 34613 +25
+ Misses 13498 13473 -25
|
What does this PR do?
This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg
Motivation
Enable Ruby to use libdatadog v16.0.1. Of particular interest, this includes improvements to crashtracking and the managed string table needed by DataDog/dd-trace-rb#4331 .
Additional Notes
N/A
How to test the change?
I've tested this release locally using the changes in DataDog/dd-trace-rb#4353 .
As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.