Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance logging and add fork handling for sessions #857

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Enhance logging and add fork handling for sessions #857

merged 5 commits into from
Feb 7, 2025

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Feb 5, 2025

  • This includes back-propagating crashtracker logs (i.e. doing the main crashtracker accept+dispatch loop directly in the sidecar).
  • Relaxes .unwrap() calls with if let to avoid spurious panics.
  • forked processes have the same session id than their parent. Do not reset the primary session on fork.

bwoebi added 3 commits February 5, 2025 19:38
@bwoebi
Ensure _DD_DEBUG_SIDECAR_LOG_LEVEL is kept as a permanent min log level
3d9b44b 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Log crashtracker errors in sidecar
b6c6615 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi
Avoid resetting the sidecar session on fork
d7acab5 
And add a few more log lines
Also fix some ordering assumptions around unrwap().

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested review from a team as code owners February 5, 2025 18:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.42857% with 48 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (2796be8) to head (e7a59c7).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   71.96%   71.93%   -0.03%     
==========================================
  Files         322      322              
  Lines       48167    48193      +26     
==========================================
+ Hits        34663    34668       +5     
- Misses      13504    13525      +21
Components Coverage Δ
crashtracker 43.25% <0.00%> (-0.07%) ⬇️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.50% <ø> (ø)
data-pipeline-ffi 91.53% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (+0.14%) ⬆️
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.01% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (ø)
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.59% <12.50%> (-0.10%) ⬇️
sidecar-ffi 2.20% <0.00%> (-0.01%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 92.79% <0.00%> (-0.81%) ⬇️
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.87% <ø> (ø)

@bwoebi bwoebi enabled auto-merge (squash) February 6, 2025 17:54
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-02-07 14:02:46

Comparing candidate commit e7a59c7 in PR branch bob/min-log with baseline commit 2796be8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.646µs 2.699µs ± 0.018µs 2.697µs ± 0.009µs 2.709µs 2.737µs 2.749µs 2.756µs 2.19% 0.241 1.260 0.68% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.697µs; 2.702µs] or [-0.095%; +0.095%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 40.424µs 41.092µs ± 0.770µs 40.813µs ± 0.120µs 40.863µs 42.729µs 42.756µs 43.488µs 6.55% 1.652 0.933 1.87% 0.054µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [40.986µs; 41.199µs] or [-0.260%; +0.260%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.411µs 3.358µs ± 1.478µs 3.162µs ± 0.026µs 3.187µs 3.783µs 14.519µs 15.526µs 391.02% 7.438 56.064 43.92% 0.105µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.153µs; 3.563µs] or [-6.102%; +6.102%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 487.471µs 488.583µs ± 1.276µs 488.453µs ± 0.234µs 488.678µs 488.993µs 497.892µs 498.987µs 2.16% 7.131 53.140 0.26% 0.090µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 2004061.788op/s 2046747.883op/s ± 5249.037op/s 2047278.135op/s ± 982.283op/s 2048396.788op/s 2049491.894op/s 2050833.614op/s 2051405.019op/s 0.20% -7.098 52.788 0.26% 371.163op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 497.276µs 498.095µs ± 0.542µs 498.043µs ± 0.202µs 498.250µs 498.597µs 499.002µs 502.797µs 0.95% 5.700 45.395 0.11% 0.038µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 1988873.613op/s 2007653.111op/s ± 2169.709op/s 2007858.653op/s ± 813.617op/s 2008634.220op/s 2009652.552op/s 2010734.284op/s 2010956.538op/s 0.15% -5.652 44.871 0.11% 153.422op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 167.496µs 168.479µs ± 0.542µs 168.360µs ± 0.373µs 168.807µs 169.486µs 169.779µs 169.835µs 0.88% 0.612 -0.525 0.32% 0.038µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5888052.512op/s 5935532.559op/s ± 19056.136op/s 5939643.279op/s ± 13153.523op/s 5950289.004op/s 5960039.584op/s 5966026.910op/s 5970295.973op/s 0.52% -0.601 -0.538 0.32% 1347.472op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.628µs 46.057µs ± 0.187µs 46.060µs ± 0.107µs 46.164µs 46.319µs 46.400µs 47.185µs 2.44% 0.880 5.431 0.41% 0.013µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21192960.453op/s 21712687.900op/s ± 88065.355op/s 21710615.048op/s ± 50336.467op/s 21766308.343op/s 21864210.010op/s 21892203.436op/s 21916370.433op/s 0.95% -0.802 4.952 0.40% 6227.161op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 43.164µs 44.248µs ± 0.307µs 44.263µs ± 0.151µs 44.410µs 44.688µs 44.919µs 45.080µs 1.85% -0.934 2.980 0.69% 0.022µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 22182577.562op/s 22600762.392op/s ± 157713.218op/s 22592457.653op/s ± 77241.997op/s 22670423.071op/s 22813861.553op/s 23133550.342op/s 23167471.862op/s 2.55% 1.020 3.162 0.70% 11152.009op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [488.406µs; 488.760µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2046020.417op/s; 2047475.349op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [498.020µs; 498.170µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2007352.411op/s; 2007953.812op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [168.404µs; 168.554µs] or [-0.045%; +0.045%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5932891.562op/s; 5938173.556op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.031µs; 46.083µs] or [-0.056%; +0.056%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21700482.889op/s; 21724892.911op/s] or [-0.056%; +0.056%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [44.206µs; 44.291µs] or [-0.096%; +0.096%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22578904.857op/s; 22622619.928op/s] or [-0.097%; +0.097%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 251.604µs 252.284µs ± 0.550µs 252.114µs ± 0.146µs 252.280µs 253.689µs 253.760µs 254.045µs 0.77% 1.797 2.049 0.22% 0.039µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3936309.497op/s 3963808.050op/s ± 8613.719op/s 3966458.349op/s ± 2300.035op/s 3968529.688op/s 3971565.538op/s 3973233.093op/s 3974504.197op/s 0.20% -1.792 2.034 0.22% 609.082op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 22.554µs 22.659µs ± 0.046µs 22.664µs ± 0.028µs 22.680µs 22.724µs 22.777µs 22.978µs 1.39% 1.852 10.751 0.20% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 43519352.247op/s 44131939.012op/s ± 89488.944op/s 44123130.876op/s ± 55313.295op/s 44191630.946op/s 44259161.759op/s 44275722.167op/s 44338102.753op/s 0.49% -1.796 10.312 0.20% 6327.824op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 13.349µs 13.413µs ± 0.044µs 13.415µs ± 0.032µs 13.448µs 13.484µs 13.512µs 13.524µs 0.81% 0.256 -0.895 0.32% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 73942490.348op/s 74553516.615op/s ± 242677.488op/s 74541569.609op/s ± 179511.942op/s 74718925.637op/s 74885229.471op/s 74897479.172op/s 74913938.154op/s 0.50% -0.246 -0.907 0.32% 17159.890op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [252.208µs; 252.360µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3962614.271op/s; 3965001.828op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [22.653µs; 22.666µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [44119536.705op/s; 44144341.319op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good execution_time [13.407µs; 13.419µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/good throughput [74519883.850op/s; 74587149.381op/s] or [-0.045%; +0.045%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.635µs 28.414µs ± 13.973µs 19.278µs ± 0.554µs 37.502µs 47.206µs 49.592µs 146.096µs 657.85% 3.723 25.876 49.05% 0.988µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.477µs; 30.350µs] or [-6.815%; +6.815%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.465µs 5.528µs ± 0.036µs 5.538µs ± 0.038µs 5.558µs 5.577µs 5.582µs 5.623µs 1.54% 0.083 -1.466 0.64% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.523µs; 5.533µs] or [-0.089%; +0.089%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.270µs 4.287µs ± 0.003µs 4.287µs ± 0.002µs 4.288µs 4.291µs 4.295µs 4.301µs 0.33% -0.164 8.458 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 232519170.877op/s 233267140.088op/s ± 153811.177op/s 233279009.842op/s ± 88343.495op/s 233360917.880op/s 233447415.562op/s 233544529.013op/s 234197888.787op/s 0.39% 0.184 8.515 0.07% 10876.093op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 88.775µs 89.578µs ± 0.322µs 89.541µs ± 0.224µs 89.781µs 90.098µs 90.488µs 90.840µs 1.45% 0.668 1.264 0.36% 0.023µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11008357.702op/s 11163590.310op/s ± 40055.808op/s 11168077.727op/s ± 27993.686op/s 11191319.174op/s 11220960.962op/s 11241427.145op/s 11264456.346op/s 0.86% -0.637 1.182 0.36% 2832.373op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 80.610µs 81.236µs ± 0.287µs 81.215µs ± 0.168µs 81.373µs 81.762µs 81.987µs 82.220µs 1.24% 0.566 0.402 0.35% 0.020µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12162516.134op/s 12309975.927op/s ± 43413.788op/s 12313049.991op/s ± 25430.994op/s 12340165.086op/s 12375813.366op/s 12399799.056op/s 12405482.578op/s 0.75% -0.544 0.369 0.35% 3069.818op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.273µs 4.288µs ± 0.005µs 4.287µs ± 0.002µs 4.289µs 4.292µs 4.302µs 4.337µs 1.16% 6.512 54.189 0.13% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230593227.517op/s 233228723.006op/s ± 295520.527op/s 233262316.499op/s ± 85239.733op/s 233347451.204op/s 233433356.976op/s 233500395.410op/s 234018319.231op/s 0.32% -6.459 53.610 0.13% 20896.457op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 77.345µs 77.675µs ± 0.211µs 77.638µs ± 0.140µs 77.793µs 78.115µs 78.280µs 78.394µs 0.97% 0.916 0.665 0.27% 0.015µs 1 200
credit_card/is_card_number/378282246310005 throughput 12756150.170op/s 12874183.559op/s ± 34812.453op/s 12880282.224op/s ± 23207.310op/s 12898877.798op/s 12918674.979op/s 12925641.449op/s 12929002.338op/s 0.38% -0.901 0.627 0.27% 2461.612op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.250µs 59.621µs ± 0.146µs 59.612µs ± 0.079µs 59.693µs 59.815µs 59.972µs 60.483µs 1.46% 1.407 8.000 0.24% 0.010µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16533491.687op/s 16772745.935op/s ± 40986.791op/s 16775045.446op/s ± 22208.869op/s 16795816.165op/s 16826414.618op/s 16868904.377op/s 16877759.212op/s 0.61% -1.349 7.679 0.24% 2898.204op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.839µs 6.852µs ± 0.008µs 6.851µs ± 0.003µs 6.854µs 6.860µs 6.899µs 6.913µs 0.90% 4.279 25.835 0.12% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 144656359.406op/s 145937708.829op/s ± 170877.348op/s 145961385.915op/s ± 64081.951op/s 146017153.366op/s 146100047.121op/s 146179315.421op/s 146215140.958op/s 0.17% -4.246 25.532 0.12% 12082.853op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.270µs 4.286µs ± 0.003µs 4.286µs ± 0.001µs 4.288µs 4.290µs 4.292µs 4.305µs 0.43% 0.376 11.189 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232305245.707op/s 233306246.969op/s ± 158759.123op/s 233307535.833op/s ± 74299.510op/s 233377533.862op/s 233513452.409op/s 233671320.194op/s 234172785.388op/s 0.37% -0.350 11.133 0.07% 11225.965op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 68.754µs 69.069µs ± 0.132µs 69.057µs ± 0.065µs 69.127µs 69.307µs 69.463µs 69.775µs 1.04% 1.173 4.082 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14331758.059op/s 14478380.290op/s ± 27603.377op/s 14480778.221op/s ± 13676.243op/s 14494327.645op/s 14515490.151op/s 14536502.600op/s 14544586.430op/s 0.44% -1.146 3.959 0.19% 1951.853op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 61.243µs 61.564µs ± 0.146µs 61.552µs ± 0.104µs 61.667µs 61.817µs 61.886µs 61.916µs 0.59% 0.214 -0.563 0.24% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16150949.349op/s 16243263.626op/s ± 38382.205op/s 16246410.406op/s ± 27574.815op/s 16272590.855op/s 16298037.232op/s 16316370.766op/s 16328483.406op/s 0.51% -0.205 -0.568 0.24% 2714.032op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.271µs 4.287µs ± 0.002µs 4.287µs ± 0.001µs 4.288µs 4.290µs 4.292µs 4.298µs 0.25% -0.968 11.468 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232682553.576op/s 233270906.659op/s ± 132809.939op/s 233273196.910op/s ± 68586.514op/s 233338063.272op/s 233418466.876op/s 233606809.101op/s 234154523.518op/s 0.38% 0.989 11.560 0.06% 9391.081op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 59.146µs 59.405µs ± 0.124µs 59.401µs ± 0.082µs 59.485µs 59.605µs 59.733µs 59.754µs 0.59% 0.282 -0.098 0.21% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16735415.556op/s 16833592.495op/s ± 35097.611op/s 16834595.075op/s ± 23176.747op/s 16857178.565op/s 16890608.154op/s 16906157.189op/s 16907395.295op/s 0.43% -0.270 -0.110 0.21% 2481.776op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.245µs 59.534µs ± 0.121µs 59.531µs ± 0.083µs 59.620µs 59.725µs 59.802µs 59.870µs 0.57% 0.041 -0.429 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16702874.455op/s 16797274.792op/s ± 34128.224op/s 16798071.581op/s ± 23564.408op/s 16820042.783op/s 16854171.083op/s 16870219.396op/s 16879153.101op/s 0.48% -0.032 -0.431 0.20% 2413.230op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.837µs 6.851µs ± 0.006µs 6.850µs ± 0.003µs 6.853µs 6.857µs 6.862µs 6.906µs 0.81% 3.910 33.019 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 144801722.307op/s 145969822.668op/s ± 129928.889op/s 145975775.320op/s ± 58876.425op/s 146034420.315op/s 146137842.329op/s 146217610.572op/s 146265193.422op/s 0.20% -3.858 32.435 0.09% 9187.360op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.287µs; 4.287µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [233245823.338op/s; 233288456.838op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [89.533µs; 89.623µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [11158038.960op/s; 11169141.660op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [81.196µs; 81.276µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12303959.193op/s; 12315992.660op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/37828224631 execution_time [4.287µs; 4.288µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631 throughput [233187766.703op/s; 233269679.309op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/378282246310005 execution_time [77.646µs; 77.705µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/378282246310005 throughput [12869358.887op/s; 12879008.230op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.601µs; 59.641µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16767065.560op/s; 16778426.310op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.851µs; 6.853µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/x371413321323331 throughput [145914026.872op/s; 145961390.786op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.286µs; 4.287µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [233284244.481op/s; 233328249.456op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.050µs; 69.087µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14474554.727op/s; 14482205.852op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [61.544µs; 61.584µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16237944.221op/s; 16248583.030op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.287µs; 4.287µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233252500.479op/s; 233289312.839op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [59.388µs; 59.422µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16828728.304op/s; 16838456.686op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.517µs; 59.550µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16792544.949op/s; 16802004.636op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.850µs; 6.852µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [145951815.774op/s; 145987829.563op/s] or [-0.012%; +0.012%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 79.267µs 79.486µs ± 0.151µs 79.476µs ± 0.035µs 79.510µs 79.576µs 79.724µs 81.419µs 2.44% 10.543 132.201 0.19% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [79.465µs; 79.507µs] or [-0.026%; +0.026%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.020ms 58.365ms ± 0.167ms 58.353ms ± 0.074ms 58.425ms 58.690ms 58.976ms 59.104ms 1.29% 1.328 3.655 0.28% 0.012ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.342ms; 58.388ms] or [-0.040%; +0.040%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.615µs 141.240µs ± 0.287µs 141.194µs ± 0.119µs 141.329µs 141.739µs 142.346µs 142.503µs 0.93% 1.731 4.572 0.20% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [141.200µs; 141.279µs] or [-0.028%; +0.028%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 286.088ns 292.606ns ± 10.277ns 288.409ns ± 1.425ns 292.019ns 318.024ns 326.675ns 327.882ns 13.69% 2.163 3.315 3.50% 0.727ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [291.182ns; 294.030ns] or [-0.487%; +0.487%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e7a59c7 1738936314 bob/min-log
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.259ms 6.277ms ± 0.008ms 6.276ms ± 0.004ms 6.281ms 6.287ms 6.296ms 6.316ms 0.64% 1.294 4.631 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.276ms; 6.278ms] or [-0.017%; +0.017%] None None None

Baseline

Omitted due to size.

@bwoebi bwoebi merged commit ee1a95a into main Feb 7, 2025
31 checks passed
@bwoebi bwoebi deleted the bob/min-log branch February 7, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees
No one assigned
Labels
crashtracker sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwoebi @codecov-commenter @morrisonlevi @realFlowControl