Skip to content

[profiling] add ffi for crossbeam::ArrayQueue #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Aug 1, 2024
Merged

[profiling] add ffi for crossbeam::ArrayQueue #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
79d7b72
array_queue
taegyunkim Jul 17, 2024
9a61b26
compiles
taegyunkim Jul 18, 2024
77377fb
len,is_empty,pop
taegyunkim Jul 18, 2024
af6b586
fix lint
taegyunkim Jul 18, 2024
9743d07
not sure whether this is right way? but builds and passes lint
taegyunkim Jul 18, 2024
c211491
pointer magic
taegyunkim Jul 19, 2024
0bafe23
add license
taegyunkim Jul 19, 2024
4df0be2
fix typo
taegyunkim Jul 19, 2024
59ef345
put in ddcommon-ffi
taegyunkim Jul 23, 2024
1e6627f
Discard changes to profiling-ffi/cbindgen.toml
taegyunkim Jul 23, 2024
94ecc77
compiles
taegyunkim Jul 23, 2024
50300cd
no leak
taegyunkim Jul 24, 2024
44116cd
Discard changes to examples/ffi/cmake_install.cmake
taegyunkim Jul 24, 2024
b4fc218
Discard changes to examples/ffi/crashinfo.cpp
taegyunkim Jul 24, 2024
f6305fc
simple mpmsc example
taegyunkim Jul 24, 2024
33c0234
update cbindgen
taegyunkim Jul 24, 2024
bf053bf
use while instead of dowhile
taegyunkim Jul 24, 2024
0238f23
delete when error
taegyunkim Jul 24, 2024
dcf7b2c
add rest of the api
taegyunkim Jul 24, 2024
3f9cf3e
make compiler happy again
taegyunkim Jul 24, 2024
8b35756
safety comments
taegyunkim Jul 24, 2024
0c0c992
cargo fmt
taegyunkim Jul 24, 2024
c14c455
address ivo's comments
taegyunkim Jul 25, 2024
85a953b
use as_inner_ref
taegyunkim Jul 25, 2024
1cb9c74
cargo clippy
taegyunkim Jul 25, 2024
aef68ef
address comments
taegyunkim Jul 26, 2024
21bc63b
safety comment
taegyunkim Jul 28, 2024
e81695e
minimal testing
taegyunkim Jul 28, 2024
449c59b
push another
taegyunkim Jul 28, 2024
fd18299
fix clippy
taegyunkim Jul 29, 2024
eceda7d
optional function pointer
taegyunkim Jul 29, 2024
391dbaf
resolve more comments
taegyunkim Jul 29, 2024
570cca9
single thread fuzzing
taegyunkim Jul 31, 2024
da75b26
run fuzzing for ddcommon-ffi
taegyunkim Jul 31, 2024
5f39db0
clippy fix
taegyunkim Jul 31, 2024
bb985a6
fix miri
taegyunkim Jul 31, 2024
9603873
Merge branch 'main' into taegyunkim/prof-10011-arrayqueue
taegyunkim Aug 1, 2024
3ad49e4
Apply suggestions from code review
taegyunkim Aug 1, 2024
cedd8f0
ArrayQueue
taegyunkim Aug 1, 2024
6abe90f
Update ddcommon-ffi/src/array_queue.rs
danielsn Aug 1, 2024
2b03b84
fix type
taegyunkim Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/fuzz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
directory: [alloc, profiling]
directory: [alloc, profiling, ddcommon-ffi]
env:
CARGO_TERM_COLOR: always
steps:
Expand Down
11 changes: 11 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions LICENSE-3rdparty.yml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions ddcommon-ffi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,9 @@ build_common = { path = "../build-common" }
[dependencies]
anyhow = "1.0"
chrono = { version = "0.4.38", features = ["std"] }
crossbeam-queue = "0.3.11"
ddcommon = { path = "../ddcommon" }
hyper = {version = "0.14", default-features = false}

[dev-dependencies]
bolero = "0.10.1"
6 changes: 6 additions & 0 deletions ddcommon-ffi/cbindgen.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ rename_types = "PascalCase"
[export.rename]
"ParseTagsResult" = "ddog_Vec_Tag_ParseResult"
"PushTagResult" = "ddog_Vec_Tag_PushResult"
"ArrayQueueNewResult" = "ddog_ArrayQueue_NewResult"
"ArrayQueuePushResult" = "ddog_ArrayQueue_PushResult"
"ArrayQueuePopResult" = "ddog_ArrayQueue_PopResult"
"ArrayQueueBoolResult" = "ddog_ArrayQueue_BoolResult"
"ArrayQueueUsizeResult" = "ddog_ArrayQueue_UsizeResult"


[enum]
prefix_with_name = true
Expand Down
Loading