Clean up

crashtracker-ffi/src/crash_info/sig_info.rs

@@ -2,22 +2,22 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use datadog_crashtracker::{SiCodes, SignalNames};
-use ddcommon_ffi::ToHexStr;
+use ddcommon_ffi::{slice::AsBytes, CharSlice};
 
 #[repr(C)]
-pub struct SigInfo {
-    pub addr: usize,
+pub struct SigInfo<'a> {
+    pub addr: CharSlice<'a>,
     pub code: libc::c_int,
     pub code_human_readable: SiCodes,
     pub signo: libc::c_int,
     pub signo_human_readable: SignalNames,
 }
 
-impl TryFrom<SigInfo> for datadog_crashtracker::SigInfo {
+impl<'a> TryFrom<SigInfo<'a>> for datadog_crashtracker::SigInfo {
     type Error = anyhow::Error;
-    fn try_from(value: SigInfo) -> anyhow::Result<Self> {
+    fn try_from(value: SigInfo<'a>) -> anyhow::Result<Self> {
         Ok(Self {
-            si_addr: Some(value.addr.to_hex_str()),
+            si_addr: value.addr.try_to_string_option()?,
             si_code: value.code,
             si_code_human_readable: value.code_human_readable,
             si_signo: value.signo,

crashtracker/src/crash_info/stacktrace.rs

@@ -192,7 +192,6 @@ impl StackFrame {
 pub enum BuildIdType {
     GNU,
     GO,
-    PDB,
     PE,
     SHA1,
 }

examples/ffi/crashinfo.cpp

@@ -120,7 +120,7 @@ void add_windows_style_frame(ddog_crasht_Handle_StackTrace* stacktrace) {
       ddog_crasht_StackFrame_with_build_id(pbd_frame.get(), to_slice_c_char("abcdef12345")),
       "failed to add build id");
   check_result(
-      ddog_crasht_StackFrame_with_build_id_type(pbd_frame.get(), DDOG_CRASHT_BUILD_ID_TYPE_PDB),
+      ddog_crasht_StackFrame_with_build_id_type(pbd_frame.get(), DDOG_CRASHT_BUILD_ID_TYPE_PE),
       "failed to add build id type");
   check_result(ddog_crasht_StackFrame_with_file_type(pbd_frame.get(), DDOG_CRASHT_FILE_TYPE_PDB),
                "failed to add file type");
@@ -242,7 +242,7 @@ int main(void) {
                "Failed to set os_info");
 
   auto sigInfo = ddog_crasht_SigInfo {
-    .addr = 0XBABEF00D,
+    .addr = "0xBABEF00D",
     .code = 16,
     .code_human_readable = DDOG_CRASHT_SI_CODES_UNKNOWN,
     .signo = -1,