Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAASINT-3691] DDS: Ivanti nZTA: Crawler Integration v1.0.0 #19583

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

shubhamvekariya-crest
Copy link
Contributor

What does this PR do?

This is a initial release PR of Ivanti nZTA integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
  • Samples for the pipeline review would also be shared separately with the required teams.
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@shubhamvekariya-crest shubhamvekariya-crest changed the title DDS: Ivanti nZTA: Crawler Integration v1.0.0 [SAASINT-3691] DDS: Ivanti nZTA: Crawler Integration v1.0.0 Feb 14, 2025
@shubhamvekariya-crest shubhamvekariya-crest marked this pull request as ready for review February 14, 2025 12:47
estherk15
estherk15 previously approved these changes Feb 14, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed estherk15’s stale review February 17, 2025 06:14

Review from estherk15 is dismissed.
Related teams and files:

  • documentation
    • ivanti_nzta/README.md
abhi-modugula
abhi-modugula previously approved these changes Feb 19, 2025
@BoyangHuang BoyangHuang added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Feb 19, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed abhi-modugula’s stale review February 19, 2025 19:07

Review from abhi-modugula is dismissed.
Related teams and files:

  • saas-integrations
    • .github/CODEOWNERS
estherk15
estherk15 previously approved these changes Feb 20, 2025
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking my suggestions, found one small fix but approved for documentation.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed estherk15’s stale review February 21, 2025 04:41

Review from estherk15 is dismissed.
Related teams and files:

  • documentation
    • ivanti_nzta/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants