Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] skip host info system metrics collection on arbiter #19571

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

This PR skips host info system metrics collection on arbiter. hostInfo command cannot be ran on arbiter node even logged in with authentication.

Motivation

https://datadoghq.atlassian.net/browse/SDBM-1491

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (ba99033) to head (a1628e8).
Report is 17 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 92.91% <100.00%> (?)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit cdcf656 Feb 7, 2025
34 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/arbiter branch February 7, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants