Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add bin path to $PATH on macos builders #19466

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Jan 23, 2025

What does this PR do?

Moves the place where ${prefix}/bin is added to $PATH from the builder setup script to the script that drives the build.

Proof that the change works on cache hits: https://github.com/DataDog/integrations-core/actions/runs/12932489195/job/36068842241?pr=19466#step:7:19.

Motivation

The current implementation makes the build fail on cache hits, as the action of setting the PATH is not part of the cache.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sethsamuel sethsamuel added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit b0ae51d Jan 23, 2025
39 checks passed
@sethsamuel sethsamuel deleted the alopez/builders-fix-macos-bin-path branch January 23, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants