Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4784] DDSaaS: Sonatype Nexus: Integration v1.0.0 #19365

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

avaid-crest
Copy link
Contributor

What does this PR do?

  • PR for a new integration Sonatype Nexus 1.0.0

Additional Notes

The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 88.30935% with 65 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (724567b) to head (24c22e2).
Report is 297 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sonatype_nexus 88.30% <88.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@avaid-crest avaid-crest changed the title DDSaaS: Sonatype Nexus: Integration v1.0.0 [AI-4784] DDSaaS: Sonatype Nexus: Integration v1.0.0 Jan 10, 2025
@avaid-crest avaid-crest marked this pull request as ready for review January 10, 2025 13:39
@avaid-crest avaid-crest requested review from a team as code owners January 10, 2025 13:39
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 10, 2025
jhgilbert
jhgilbert previously approved these changes Feb 19, 2025
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some suggestions for style, thanks!


1. The `Username` and `Password` of either the **Administrator** account or a user with the **nx-metrics-all** privilege

2. The `Server URL` of the Repository instance. For Ex: https://123.123.123.123:8081
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. The `Server URL` of the Repository instance. For Ex: https://123.123.123.123:8081
2. The `Server URL` of the Repository instance (for example, https://123.123.123.123:8081)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes as per your suggestion.


2. The `Server URL` of the Repository instance. For Ex: https://123.123.123.123:8081

### Connect your Sonatype Nexus account to agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Connect your Sonatype Nexus account to agent
### Connect your Sonatype Nexus account to the Agent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated the changes.


### Events

The Sonatype Nexus integration forwards below events to Datadog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Sonatype Nexus integration forwards below events to Datadog.
The Sonatype Nexus integration forwards the below events to Datadog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes as per your suggestion.

@@ -0,0 +1,1227 @@
{
"title": "Sonatype Nexus Metrics",
"description": "This dashboard provides insights into Sonatype Nexus repository performance, resource utilization, and activity trends. It tracks instance uptime, memory usage, repository statistics, blobstore metrics, and data transfers. and security metrics, including vulnerabilities and cleanup operations.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "This dashboard provides insights into Sonatype Nexus repository performance, resource utilization, and activity trends. It tracks instance uptime, memory usage, repository statistics, blobstore metrics, and data transfers. and security metrics, including vulnerabilities and cleanup operations.",
"description": "This dashboard provides insights into Sonatype Nexus repository performance, resource utilization, and activity trends. It tracks instance uptime, memory usage, repository statistics, blobstore metrics, data transfers, and security metrics, including vulnerabilities and cleanup operations.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes as per your suggestion.

"critical"
],
"name": "Sonatype Nexus Status",
"description": "Returns `CRITICAL` if the user configurations are invalid or sonatype nexus authentication fails. Returns `OK` otherwise."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Returns `CRITICAL` if the user configurations are invalid or sonatype nexus authentication fails. Returns `OK` otherwise."
"description": "Returns `CRITICAL` if the user configurations are invalid or Sonatype Nexus authentication fails. Returns `OK` otherwise."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes.

"configuration": "README.md#Setup",
"support": "README.md#Support",
"changelog": "CHANGELOG.md",
"description": "Gain insights into sonatype nexus analytics and instance health data.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Gain insights into sonatype nexus analytics and instance health data.",
"description": "Gain insights into Sonatype Nexus analytics and instance health data.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changes as per your suggestion.

@avaid-crest avaid-crest requested a review from a team as a code owner February 20, 2025 13:04
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed jhgilbert’s stale review February 20, 2025 13:04

Review from jhgilbert is dismissed.
Related teams and files:

  • documentation
    • sonatype_nexus/README.md
    • sonatype_nexus/assets/dashboards/sonatype_nexus_metrics.json
    • sonatype_nexus/assets/service_checks.json
    • sonatype_nexus/manifest.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants