Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent way to get github token when updating dependencies #19090

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Nov 20, 2024

What does this PR do?

Tested with https://github.com/DataDog/integrations-core/actions/runs/11935029894/job/33265608105 (the failure is unrelated, we checked).

Motivation

Doing different things with the same result is confusing.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@iliakur iliakur added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit 06135a3 Nov 21, 2024
58 of 61 checks passed
@iliakur iliakur deleted the ik/consistent-github-token-envvar branch November 21, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants