Argo Rollout Recommended Monitor #17298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhgilbert
approved these changes
Mar 27, 2024
Kyle-Neale
approved these changes
Mar 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
* argo rollouts rec monitor * argo rollouts rec monitor manifest * fix query * fix manifest * fix tags a704547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Argo Rollout recommended monitor. Looks at a metric that reports the phase of the rollout. It alerts if a rollout is ever in the InvalidSpec, Aborted, Error or TimeOut phase for 10 minutes.
staging link:
https://dd.datad0g.com/monitors/recommended?q=argo_rollouts&only_installed=true&p=1