Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host tags to triggered events #17287

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Add host tags to triggered events #17287

merged 6 commits into from
Mar 28, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Mar 26, 2024 •
edited
Loading

What does this PR do?

Add host tags to triggered events

Motivation

https://datadoghq.atlassian.net/browse/AI-3793

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@Kyle-Neale Kyle-Neale changed the title Event host resolution Add Mongo tags to triggered events Mar 26, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.48%. Comparing base (51725dc) to head (3b6f29a).
Report is 19 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 96.14% <91.30%> (-0.07%) ⬇️
presto ?
solr ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Test Results

 16 files   16 suites   2m 51s ⏱️
 97 tests  97 ✅   0 💤 0 ❌
808 runs  620 ✅ 188 💤 0 ❌

Results for commit 3b6f29a.

♻️ This comment has been updated with latest results.

@Kyle-Neale Kyle-Neale changed the title Add Mongo tags to triggered events Add host tags to triggered events Mar 27, 2024
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale marked this pull request as ready for review March 28, 2024 17:12
@Kyle-Neale Kyle-Neale requested review from a team as code owners March 28, 2024 17:12
rtrieu
rtrieu previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveny91
Copy link
Contributor

Nit. I'm not sure what is the correct changelog to add here. Yes you're adding a feature but it can also be classified as a change.

@Kyle-Neale Kyle-Neale merged commit f6e46e2 into master Mar 28, 2024
35 checks passed
@Kyle-Neale Kyle-Neale deleted the kyleneale/add_event_tags branch March 28, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

@rtrieu rtrieu rtrieu left review comments

Assignees
No one assigned
Labels
documentation integration/mongo team/agent-integrations team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kyle-Neale @steveny91 @rtrieu