Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new linter change (ordering facet attributes) #16667

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Apply new linter change (ordering facet attributes) #16667

merged 1 commit into from
Jan 19, 2024

Conversation

thibaultkrebs
Copy link
Contributor

@thibaultkrebs thibaultkrebs commented Jan 19, 2024 •
edited by jira bot
Loading

Context

We are working on a feature to sort facet attributes (https://datadoghq.atlassian.net/browse/[LOGSC-746](https://datadoghq.atlassian.net/browse/LOGSC-746)).

This PR is to apply change with the new linter check.

@thibaultkrebs thibaultkrebs requested review from a team as code owners January 19, 2024 13:50
@thibaultkrebs thibaultkrebs requested a review from a team January 19, 2024 13:50
@thibaultkrebs thibaultkrebs requested review from a team as code owners January 19, 2024 13:50
@nmuesch
Copy link
Collaborator

nmuesch commented Jan 19, 2024

Should be no functional changes here and is only a sorting change

@thibaultkrebs thibaultkrebs merged commit 3b6891a into master Jan 19, 2024
100 of 107 checks passed
@thibaultkrebs thibaultkrebs deleted the thibault.krebs/logs-integrations-sort-facets branch January 19, 2024 14:22
@Kyle-Neale Kyle-Neale mentioned this pull request Jan 24, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@nmuesch nmuesch nmuesch approved these changes

@nenadnoveljic nenadnoveljic nenadnoveljic approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/activemq integration/airflow integration/ambari integration/apache integration/argocd integration/azure_active_directory integration/azure_iot_edge integration/boundary integration/cacti integration/calico integration/cassandra integration/ceph integration/clickhouse integration/confluent_platform integration/coredns integration/couch integration/druid integration/elastic integration/envoy integration/etcd integration/exchange_server integration/flink integration/foundationdb integration/gearmand integration/gitlab_runner integration/gitlab integration/glusterfs integration/gunicorn integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/hive integration/hivemq integration/hudi integration/ibm_ace integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/ignite integration/iis integration/impala integration/istio integration/jboss_wildfly integration/jmeter integration/kafka integration/karpenter integration/kong integration/kyototycoon integration/lighttpd integration/mapr integration/mapreduce integration/marathon integration/marklogic integration/mcache integration/mesos_slave integration/mongo integration/mysql integration/nginx_ingress_controller integration/nginx integration/openldap integration/openstack integration/pan_firewall integration/pgbouncer integration/postfix integration/postgres integration/presto integration/proxysql integration/pulsar integration/ray integration/redisdb integration/rethinkdb integration/riak integration/scylla integration/sidekiq integration/solr integration/sonarqube integration/spark integration/sqlserver integration/squid integration/ssh_check integration/teamcity integration/temporal integration/tenable integration/tomcat integration/torchserve integration/traffic_server integration/twemproxy integration/twistlock integration/varnish integration/vault integration/vertica integration/voltdb integration/weblogic integration/yarn integration/zk team/agent-integrations team/container-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thibaultkrebs @nmuesch @FlorentClarret @nenadnoveljic